feat(ORM): outofband topology manager #435
Conversation
WangZzzhe
requested review from
csfldf,
luomingmeng and
waynepeking348
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 54.54% 55.01% +0.47%
==========================================
Files 493 502 +9
Lines 53793 54580 +787
==========================================
+ Hits 29340 30028 +688
- Misses 21242 21312 +70
- Partials 3211 3240 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WangZzzhe
force-pushed
the
dev/outofband-topology-manager
branch
from
1d874f4 to
44ba1c2
Compare
WangZzzhe
force-pushed
the
dev/outofband-topology-manager
branch
from
44ba1c2 to
e2ccb25
Compare
|
@caohe pls have a look for this pr |
| // this function for each hint provider, and merges the hints to produce | ||
| // a consensus "best" hint. The hint providers may subsequently query the | ||
| // topology manager to influence actual resource assignment. | ||
| GetTopologyHints(pod *v1.Pod, container *v1.Container) map[string][]TopologyHint |
There was a problem hiding this comment.
Do we also need GetPodTopologyHints?
There was a problem hiding this comment.
Do we also need
GetPodTopologyHints?
yes, if we want to allocate resources for dedicated cores pods on specific NUMA nodes, this is the only way to get available hints from QRMPlugins.
There was a problem hiding this comment.
It seems GetPodTopologyHints has not been defined and implemented yet. Could you also add it?
There was a problem hiding this comment.
It seems
GetPodTopologyHintshas not been defined and implemented yet. Could you also add it?
sorry I misunderstood you question, GetPodTopologyHints is not implemented by QRM plugins so we don't need it.
I add GetPodTopologyHints for ORM manager and it only returns nil now.
There was a problem hiding this comment.
According to offline discussions, we can leave an empty implementation now and implement it later. Maybe we can record a TODO in the comment. cc @WangZzzhe
WangZzzhe
force-pushed
the
dev/outofband-topology-manager
branch
from
2194942 to
85ece23
Compare
WangZzzhe
force-pushed
the
dev/outofband-topology-manager
branch
from
85ece23 to
3b4434b
Compare
caohe
added
the
workflow/merge-ready
What type of PR is this?
Enhancements
What this PR does / why we need it:
Add topology manager with policies(none, best-effort, restrict, single-numa-node, numeric) for ORM.
Pods added by ORM should GetTopologyHints from QRM plugins and generated a best hint by topology manager policy before allocate resource. Dedicated-cores pods with numaBinding can be allocated resource by this way in ORM.