Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1.4.0 perf and scale benchmarks data #13204

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add v1.4.0 perf and scale benchmarks data #13204

merged 1 commit into from
Nov 11, 2024

Conversation

Sreeja1725
Copy link

What this PR does

After this PR: This PR adds the perf and scale benchmarks data for release v1.4.0

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

Add release v1.4.0 perf and scale benchmarks data

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 7, 2024
@kubevirt-bot
Copy link
Contributor

Hi @Sreeja1725. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the sig/scale label Nov 7, 2024
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 7, 2024
@Sreeja1725 Sreeja1725 marked this pull request as draft November 7, 2024 09:02
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@xpivarc
Copy link
Member

xpivarc commented Nov 7, 2024

/cc

@kubevirt-bot kubevirt-bot requested a review from xpivarc November 7, 2024 14:06
@Sreeja1725 Sreeja1725 force-pushed the release-1.4-data branch 2 times, most recently from 704ee0d to 2d5f7ee Compare November 8, 2024 06:09
@Sreeja1725 Sreeja1725 marked this pull request as ready for review November 8, 2024 06:10
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
@Sreeja1725
Copy link
Author

/cc @alaypatel07

@alaypatel07
Copy link
Contributor

adding reviewers from sig-scale, removing others to stop the spamming

/cc @rthallisey
/uncc @acardace @jean-edouard @vasiliy-ul @lyarwood

@kubevirt-bot kubevirt-bot requested review from rthallisey and removed request for lyarwood, acardace, jean-edouard and vasiliy-ul November 8, 2024 13:22
@alaypatel07
Copy link
Contributor

/ok-to-test

alaypatel07
alaypatel07 reviewed Nov 8, 2024
View reviewed changes
docs/perf-scale-benchmarks.md

NOTE: The scalability metrics were hampered by a bug, that was fixed before the release [here](https://github.com/kubevirt/kubevirt/pull/12096). Hence the scalability metrics data needs to be re-evaluated by users with the bug fix to get a more accurate benchmarks
Note: virt-api and virt-controller memory usage is being collected from June 27th
Copy link
Contributor

@alaypatel07 alaypatel07 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in data in CPU graphs related to the promql bugfix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added only the avg cpu and memory graphs in this doc, those are not related to bugfix.

alaypatel07
alaypatel07 reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@alaypatel07 alaypatel07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one question if clarification regarding bugfix is required. Apart from this the PR LGTM. Thanks @Sreeja1725

@alaypatel07
Copy link
Contributor

/lgtm
/retest-required

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@alaypatel07
Copy link
Contributor

/cherry-pick release-1.4

@kubevirt-bot
Copy link
Contributor

@alaypatel07: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@kubevirt-bot kubevirt-bot added area/virtctl sig/buildsystem Denotes an issue or PR that relates to changes in the build system. size/L and removed size/M labels Nov 8, 2024
@kubevirt-bot kubevirt-bot added size/M and removed size/L labels Nov 8, 2024
@alaypatel07
Copy link
Contributor

/retest-required

@rthallisey
Copy link
Contributor

/approve

@alaypatel07
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
xpivarc
xpivarc reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rthallisey, xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator

@kubevirt-bot kubevirt-bot merged commit 9a20eb3 into kubevirt:main Nov 11, 2024
38 checks passed
@kubevirt-bot
Copy link
Contributor

@alaypatel07: new pull request created: #13217

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@alaypatel07 alaypatel07 alaypatel07 left review comments

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees

@alaypatel07 alaypatel07

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/virtctl dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/scale size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sreeja1725 @kubevirt-bot @xpivarc @alaypatel07 @rthallisey @kubevirt-commenter-bot