Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump multus to v4.1.0 #1864

Closed
wants to merge 1 commit into from
Closed

Conversation

kubevirt-bot
Copy link
Collaborator

bump multus to v4.1.0
Executed by Bumper script

bump multus to v4.1.0

Signed-off-by: CNAO Bump Bot <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 15, 2024
@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@oshoval
Copy link
Collaborator

oshoval commented Aug 15, 2024

/hold

multus bump is broken here
#1847

and we dont have yet the lanes for this release

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
@oshoval oshoval mentioned this pull request Aug 15, 2024
@oshoval
Copy link
Collaborator

oshoval commented Aug 15, 2024

@kubevirt-bot
Copy link
Collaborator Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cnao-macvtap-cni-functests-release-0.95 fc5a62f link true /test pull-e2e-cnao-macvtap-cni-functests-release-0.95
pull-e2e-cnao-ovs-cni-functests-release-0.95 fc5a62f link true /test pull-e2e-cnao-ovs-cni-functests-release-0.95

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RamLavi
Copy link
Collaborator

RamLavi commented Aug 15, 2024

@oshoval
Copy link
Collaborator

oshoval commented Aug 15, 2024

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1864/pull-e2e-cnao-macvtap-cni-functests-release-0.95/1824053768279298048
might be real bug due to the bump
maybe MacVtap should be static ? (there is a PR for that) #1862

@maiqueb ?

better have it first on main, as on the release it is going to be static right ? (i.e no auto bump iiuc)
I will open an issue once it appears on main bump
Issue will allow to track it better as you also suggested offline in other case lately

@oshoval
Copy link
Collaborator

oshoval commented Aug 15, 2024

/close

if the error return on main we can open an issue imo
EDIT - updated this ticket #1858

@oshoval oshoval closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants