Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump linux bridge CNI #1544

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Apr 24, 2023

What this PR does / why we need it:
This introduces a bug fix resolving an issue where deleting pods took too long when there were many rules / chains in the kubernetes node [0].

[0] - https://bugzilla.redhat.com/show_bug.cgi?id=2175041

Special notes for your reviewer:
Unfortunately, this time, there were (at least one) feature merged in container-networking CNI project: containernetworking/plugins#829

Release note:

Address performance issues of bridge-cni when deleting pods

This introduces a bug fix resolving an issue where deleting pods took
too long when there were many rules / chains in the kubernetes node [0].

[0] - https://bugzilla.redhat.com/show_bug.cgi?id=2175041

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 24, 2023
@maiqueb
Copy link
Contributor Author

maiqueb commented Apr 24, 2023

/cc @phoracek I need you to do your image generation + pushing magic for this to work.

Feel free to push on top / loot this PR.

Signed-off-by: Petr Horacek <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maiqueb
Copy link
Contributor Author

maiqueb commented Apr 25, 2023

/test pull-e2e-cnao-multus-dynamic-networks-functests

1 similar comment
@maiqueb
Copy link
Contributor Author

maiqueb commented Apr 25, 2023

/test pull-e2e-cnao-multus-dynamic-networks-functests

@maiqueb
Copy link
Contributor Author

maiqueb commented Apr 25, 2023

There's a problem in the teardown of pull-e2e-cnao-multus-dynamic-networks-functests when used on kubevirtci providers.

Working on it ...

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@maiqueb
Copy link
Contributor Author

maiqueb commented Apr 27, 2023

@phoracek / @qinqon can we get an override on the pull-e2e-cnao-multus-dynamic-networks-functests lane ?

I'm trying to sort that out, but I can't provide an ETA right now.

@qinqon
Copy link
Collaborator

qinqon commented Apr 27, 2023

/override pull-e2e-cnao-multus-dynamic-networks-functests

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-e2e-cnao-multus-dynamic-networks-functests

In response to this:

/override pull-e2e-cnao-multus-dynamic-networks-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maiqueb
Copy link
Contributor Author

maiqueb commented Apr 27, 2023

/hold cancel

Let's defer fixing the multus-dynamic-tests.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2023
@qinqon
Copy link
Collaborator

qinqon commented Apr 27, 2023

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@kubevirt-bot kubevirt-bot merged commit a0a408f into kubevirt:main Apr 27, 2023
@maiqueb maiqueb deleted the mac-spoof-read-only-required-chain-when-deleting branch April 27, 2023 14:24
@phoracek
Copy link
Member

/cherry-pick release-0.85

@kubevirt-bot
Copy link
Collaborator

@phoracek: #1544 failed to apply on top of branch "release-0.85":

Applying: Bump linux bridge CNI
Using index info to reconstruct a base tree...
M	components.yaml
M	pkg/components/components.go
M	test/releases/99.0.0.go
Falling back to patching base and 3-way merge...
Auto-merging test/releases/99.0.0.go
Auto-merging pkg/components/components.go
CONFLICT (content): Merge conflict in pkg/components/components.go
Auto-merging components.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump linux bridge CNI
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.85

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phoracek
Copy link
Member

Manual cherry-pick: #1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants