[MTV-1969] Add bulk select dropdown for selectable tables #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuzz0
added
the
enhancement
jpuzz0
force-pushed
the
MTV-1969-bulk-select-dropdown
branch
from
d781acf to
b6e322a
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
- Coverage 36.81% 36.32% -0.50%
==========================================
Files 158 156 -2
Lines 2548 2522 -26
Branches 599 602 +3
==========================================
- Hits 938 916 -22
+ Misses 1428 1421 -7
- Partials 182 185 +3 ☔ View full report in Codecov by Sentry. |
jpuzz0
force-pushed
the
MTV-1969-bulk-select-dropdown
branch
7 times, most recently
from
28a5a9d to
120dd0c
Compare
Signed-off-by: Jeff Puzzo <[email protected]>
jpuzz0
force-pushed
the
MTV-1969-bulk-select-dropdown
branch
from
120dd0c to
5db9ac8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Links
📝 Description
Replaced the previous temp solution of displaying the amount of VMs selected with muted text next to pagination (floated to the top right of tables), with a bulk select dropdown which more clearly shows what is selected on a given page for the VMs list table. This change is in accordance with PF guidelines referenced above and introduces a new package,
@patternfly/react-component-groupsto use an existing BulkSelect component.🎥 Demo
Screen.Recording.2025-01-30.at.11.28.19.AM.mov
📝 CC://
@mmenestr