Update the "Max concurrent vm migrations" field descriptions and links

Reference: https://issues.redhat.com/browse/MTV-1212 - Update the "Max concurrent virtual machine migrations" field descriptions, doc reference and edit dialog text within the overview -settings card, based on doc changes https://issues.redhat.com/browse/MTV-1211. - Update the doc references for all other Overview -> settings card fields as well. Signed-off-by: Sharon Gratch <[email protected]>
kubev2v · Feb 5, 2025 · 6cf0ee3 · 6cf0ee3
1 parent 9557b49
commit 6cf0ee3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
@@ -240,8 +240,8 @@
   "Map": "Map",
   "Map source datastores, storage domains, volume types, storage classes and networks to their respective target storage classes and networks.": "Map source datastores, storage domains, volume types, storage classes and networks to their respective target storage classes and networks.",
   "Mappings": "Mappings",
-  "Maximum concurrent VM migrations": "Maximum concurrent VM migrations",
-  "Maximum number of concurrent VM migrations. Default value is 20.": "Maximum number of concurrent VM migrations. Default value is 20.",
+  "Maximum concurrent VM or disk migrations": "Maximum concurrent VM or disk migrations",
+  "Maximum number of concurrent VM or disk migrations. Default value is 20.": "Maximum number of concurrent VM or disk migrations. Default value is 20.",
   "Message": "Message",
   "Message: {{message}}": "Message: {{message}}",
   "Method of authentication to use when connecting to the OpenStack Identity (Keystone) server.": "Method of authentication to use when connecting to the OpenStack Identity (Keystone) server.",
@@ -365,7 +365,7 @@
   "Please enter the limit for CPU usage by the controller in milliCPU, if empty default value will be used.": "Please enter the limit for CPU usage by the controller in milliCPU, if empty default value will be used.",
   "Please enter the limit for memory usage by the controller in Mi, if empty default value will be used.": "Please enter the limit for memory usage by the controller in Mi, if empty default value will be used.",
   "Please enter the limit for memory usage by the inventory container in Mi, if empty default value will be used.": "Please enter the limit for memory usage by the inventory container in Mi, if empty default value will be used.",
-  "Please enter the maximum number of concurrent VM migrations, if empty default value will be used.": "Please enter the maximum number of concurrent VM migrations, if empty default value will be used.",
+  "Please enter the maximum number of concurrent VM or disk migrations, if empty default value will be used.": "Please enter the maximum number of concurrent VM or disk migrations, if empty default value will be used.",
   "Pod": "Pod",
   "Pod logs": "Pod logs",
   "Pod network": "Pod network",
@@ -432,7 +432,6 @@
   "Set to preserve the CPU model": "Set to preserve the CPU model",
   "Set to preserve the static IPs": "Set to preserve the static IPs",
   "Set warm migration": "Set warm migration",
-  "Sets the maximum number of VMs that can be migrated simultaneously. The default value is 20 virtual machines.": "Sets the maximum number of VMs that can be migrated simultaneously. The default value is 20 virtual machines.",
   "Sets the memory limits allocated to the inventory container in the controller pod. The default value is 1000Mi.": "Sets the memory limits allocated to the inventory container in the controller pod. The default value is 1000Mi.",
   "Sets the memory limits allocated to the main container in the controller pod. The default value is 800Mi.": "Sets the memory limits allocated to the main container in the controller pod. The default value is 800Mi.",
   "Settings": "Settings",

diff --git a/packages/forklift-console-plugin/src/modules/Overview/modal/EditMaxVMInFlightModal.tsx b/packages/forklift-console-plugin/src/modules/Overview/modal/EditMaxVMInFlightModal.tsx
@@ -33,12 +33,12 @@ export const EditMaxVMInFlightModal: React.FC<EditSettingsModalProps> = (props)
       resource={resource}
       jsonPath={'spec.controller_max_vm_inflight'}
       title={props?.title || t('Edit Maximum concurrent VM migrations')}
-      label={props?.label || t('Maximum concurrent VM migrations')}
+      label={props?.label || t('Maximum concurrent VM or disk migrations')}
       model={ForkliftControllerModel}
       variant={ModalVariant.small}
-      body={t('Maximum number of concurrent VM migrations. Default value is 20.')}
+      body={t('Maximum number of concurrent VM or disk migrations. Default value is 20.')}
       helperText={t(
-        'Please enter the maximum number of concurrent VM migrations, if empty default value will be used.',
+        'Please enter the maximum number of concurrent VM or disk migrations, if empty default value will be used.',
       )}
       InputComponent={MaxVMInFlightNumberInput}
       onConfirmHook={defaultOnConfirmWithIntValue}

diff --git a/...ft-console-plugin/src/modules/Overview/views/overview/tabs/Details/cards/SettingsCard.tsx b/...ft-console-plugin/src/modules/Overview/views/overview/tabs/Details/cards/SettingsCard.tsx
@@ -9,7 +9,7 @@ import {
 } from 'src/modules/Overview/modal';
 import { ModalHOC, useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
-import { useForkliftTranslation } from 'src/utils/i18n';
+import { ForkliftTrans, useForkliftTranslation } from 'src/utils/i18n';
 
 import { V1beta1ForkliftController } from '@kubev2v/types';
 import { Card, CardBody, CardTitle, DescriptionList, Text } from '@patternfly/react-core';
@@ -42,14 +42,17 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
               )
             }
             moreInfoLink={
-              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options_mtv'
+              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#max-concurrent-vms_mtv'
             }
             helpContent={
-              <Text>
-                {t(
-                  'Sets the maximum number of VMs that can be migrated simultaneously. The default value is 20 virtual machines.',
-                )}
-              </Text>
+              <ForkliftTrans>
+                Sets the maximum number of virtual machines or disks that can be migrated
+                simultaneously, varies by the source provider type and by the settings of the
+                migration.
+                <br />
+                <br />
+                The default value is 20 virtual machines or disks.
+              </ForkliftTrans>
             }
             crumbs={['spec', 'controller_max_vm_inflight']}
             onEdit={() => showModal(<EditMaxVMInFlightModal resource={obj} />)}
@@ -64,7 +67,7 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
               )
             }
             moreInfoLink={
-              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options_mtv'
+              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#mtv-settings_mtv'
             }
             helpContent={
               <Text>
@@ -86,7 +89,7 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
               )
             }
             moreInfoLink={
-              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options_mtv'
+              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#mtv-settings_mtv'
             }
             helpContent={
               <Text>
@@ -108,7 +111,7 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
               )
             }
             moreInfoLink={
-              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options_mtv'
+              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#mtv-settings_mtv'
             }
             helpContent={
               <Text>
@@ -130,7 +133,7 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
               )
             }
             moreInfoLink={
-              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options_mtv'
+              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#mtv-settings_mtv'
             }
             helpContent={
               <Text>
@@ -152,7 +155,7 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
               )
             }
             moreInfoLink={
-              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options_mtv'
+              'https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#mtv-settings_mtv'
             }
             helpContent={
               <Text>