✨ Added support to run loki queries against openshift loki installation ✨ #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seepgoel
changed the title
pdettori
reviewed
Jun 14, 2024
|
|
||
| log_type := os.Getenv("LOG_TYPE") | ||
| tls_cert_file := os.Getenv("TLS_CERT_FILE") | ||
| tls_key_file := os.Getenv("TLS_KEY_FILE") |
There was a problem hiding this comment.
@Seep-Goel this looks good, could you perhaps add some comment on how to retrieve or generate the required TLS_CERT_FILE and `TLS_KEY_FILE' ?
There was a problem hiding this comment.
Sure, will add comments in the script.
There was a problem hiding this comment.
@pdettori ...this has been addressed in my latest commit. I'm happy to incorporate any additional feedback you have on the PR.
Signed-off-by: Seep Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing Loki query script works on the Kind deployment which uses dev version of Loki. However, Loki production deployment on openshift needed some changes to the script to work, such as:
kubernetes_pod_name, for container we havekubernetes_container_name.X-Scope-OrgIDheader to be set to eitherapplication,infrastructureoraudit.Related issue(s)
Fixes #
This PR adds a new variable
LOKI_INSTALL_TYPEwhich can be eitheropenshiftordev. And based onLOKI_INSTALL_TYPEconstructs a proper request to be sent to loki.