added kueue integration code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwiklik <[email protected]>
pdettori
reviewed
May 28, 2024
| v1beta1 "sigs.k8s.io/kueue/apis/kueue/v1beta1" | ||
| ) | ||
|
|
||
| // ClusterMetricsReconciler reconciles a ClusterMetrics object |
There was a problem hiding this comment.
Thanks @cwiklik for submitting this PR for kueue - overall it looks good. Could you pls. add in the comment what is the purpose of this clustermetrics_controller (to distinguish this from the cluster metrics controller that already exists ) - I assume it's about updating quotas automatically based on cluster metrics but it would be good to explain.
…nager-controller Signed-off-by: cwiklik <[email protected]>
pdettori
reviewed
May 29, 2024
charts/kueue-ks/values.yaml
Outdated
|
|
||
| image: | ||
| repository: nginx | ||
| pullPolicy: IfNotPresent |
There was a problem hiding this comment.
I assume this is not used in the chart, right ? I would suggest to set it to empty. Even better, remove all that is not used in the chart (probably most of it)
kueue-ks/README.md
Outdated
|
|
||
| ## License | ||
|
|
||
| Copyright 2024. |
There was a problem hiding this comment.
s/Copyright 2024./Copyright 2024 The KubeStellar Authors./
Signed-off-by: cwiklik <[email protected]>
Signed-off-by: cwiklik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation of kueue and kubestellar integration. Includes scripts and helm chart to install in Kubernetes. I've modified clustermetrics Makefile to add new targets specific to k3d local install (via ko).