fix(WebhookServer): Fix webhook EOF error when creating resources (#338) #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhargav-InfraCloud
force-pushed
the
br_fix_webhook_eof_error
branch
from
1cb04e6 to
9a10cb6
Compare
YachikaRalhan
approved these changes
Feb 28, 2024
Bhargav-InfraCloud
requested review from
narmidm,
bharath-avesha,
Rahul-D78,
gourishkb and
mridulgain
as code owners
bharath-avesha
approved these changes
Feb 28, 2024
narmidm
approved these changes
Feb 29, 2024
|
@Rahul-D78 @gourishkb @mridulgain Can you please review this PR? Thanks! |
gourishkb
approved these changes
Mar 4, 2024
Assign the `decoder` field directly during initialization of `WebhookServer` in main package. Remove `InjectDecoder` method on `WebhookServer` as the `controller-runtime` package no longer allows injections. Fixes kubeslice#338 Signed-off-by: Bhargav Ravuri <[email protected]>
Bhargav-InfraCloud
force-pushed
the
br_fix_webhook_eof_error
branch
from
9a10cb6 to
39136af
Compare
|
Rebased with the latest master. Please trigger the E2E pipeline. Thanks! |
mridulgain
approved these changes
Mar 7, 2024
|
Thanks all! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assign the
decoderfield directly during the initialization ofWebhookServerin the main package.Remove the
InjectDecodermethod onWebhookServeras thecontroller-runtimepackage no longer allows injections.Fixes #338
How Has This Been Tested?
This is an error with initialization and cannot be tested as a feature.
Steps to test this manually are in #338.
Checklist:
go fmtDoes this PR introduce a breaking change?