Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe how plugins can be consumed within Botkube core #859

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

mszostok
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • Describe how plugins can be consumed within Botkube core

Related issue(s)

@mszostok mszostok added enhancement New feature or request documentation Documetation is missing or incorrect labels Nov 22, 2022
@mszostok mszostok force-pushed the plugin-mgmt-proposal branch 4 times, most recently from 13be577 to 9f21e59 Compare November 22, 2022 13:15
@mszostok mszostok force-pushed the plugin-mgmt-proposal branch from 9f21e59 to 7bdbc04 Compare November 22, 2022 13:44
@mszostok mszostok marked this pull request as ready for review November 22, 2022 13:44
@mszostok mszostok requested a review from a team November 22, 2022 13:44
@mszostok mszostok requested a review from PrasadG193 as a code owner November 22, 2022 13:44
@mszostok mszostok requested review from josefkarasek, huseyinbabal and pkosiec and removed request for josefkarasek November 22, 2022 13:44
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀 Overall LGTM with a few small comments. Plugin conflicts are one thing which concerns me, and I have also small suggestions to fetching the plugin binary.

@huseyinbabal
Copy link
Contributor

huseyinbabal commented Nov 23, 2022

Thanks for the valuable work 🚀 Let's recap tomorrow, we can easily have a consensus and unblock you :)

Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few minor comments 🚀

@pkosiec pkosiec added this to the v0.16.0 milestone Nov 28, 2022
@huseyinbabal huseyinbabal self-requested a review November 28, 2022 15:29
@mszostok mszostok enabled auto-merge (squash) November 28, 2022 16:25
@mszostok mszostok disabled auto-merge November 28, 2022 17:45
@mszostok mszostok merged commit 4ca4307 into kubeshop:main Nov 28, 2022
@mszostok mszostok deleted the plugin-mgmt-proposal branch November 28, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documetation is missing or incorrect enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants