Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use kubeconfig from exec input #1060

Merged
merged 2 commits into from
May 12, 2023
Merged

use kubeconfig from exec input #1060

merged 2 commits into from
May 12, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Kubectl executor uses kubeconfig from exec input

Testing

  • Build plugins
  • Run plugin server
  • Run botkube with kubectl plugin enabled ( be aware you use local plugin server)

Related issue(s)

Relates #1021

@huseyinbabal huseyinbabal requested a review from a team May 11, 2023 15:25
@huseyinbabal huseyinbabal requested a review from PrasadG193 as a code owner May 11, 2023 15:25
@huseyinbabal huseyinbabal requested a review from mszostok May 11, 2023 15:25
@huseyinbabal huseyinbabal mentioned this pull request May 11, 2023
Closed
@mszostok mszostok self-assigned this May 12, 2023
@mszostok mszostok added the bug Something isn't working label May 12, 2023
mszostok
mszostok approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested e2e, LGTM 👍

@huseyinbabal huseyinbabal merged commit e155f82 into kubeshop:main May 12, 2023
@huseyinbabal huseyinbabal deleted the kubectl-executor-kubeconfig branch May 12, 2023 08:56
pkosiec pushed a commit to pkosiec/botkube that referenced this pull request May 12, 2023
@huseyinbabal @pkosiec
use kubeconfig from exec input (kubeshop#1060)
5f35e37 
(cherry picked from commit e155f82)
pkosiec pushed a commit that referenced this pull request May 12, 2023
@huseyinbabal @pkosiec
use kubeconfig from exec input (#1060)
dc03e74 
(cherry picked from commit e155f82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@mszostok mszostok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @mszostok