Fixes bad label reference in "Creating a Service" section of connecting-applications.md #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-applications.md My assumption here is that the linked service yaml file (`nginx-svc.yaml`) is correct and the text that refers to the contents of that file is incorrect. If that assumption is false, the `nginx-svc.yaml` file should be changed instead. But I suspect it is linked into multiple other docs and that this issue is the result of someone updating the file without updating all docs that reference it.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
I think we should stick with the |
|
Lets go with |
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Feb 24, 2021
Fixes linkerd/linkerd2#5606 Signed-off-by: Alex Leong <[email protected]>
Okabe-Junya
pushed a commit
to Okabe-Junya/website
that referenced
this pull request
Dec 4, 2023
[zh] Keep the subheadings consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My assumption here is that the linked service yaml file (
nginx-svc.yaml) is correct and the text that refers to the contents of that file is incorrect.If that assumption is false, the
nginx-svc.yamlfile should be changed instead. But I suspect it is linked into multiple other docs and that this issue is the result of someone updating the file without updating all docs that reference it.