Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old docker-multinode in favor for the new one #876

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

luxas
Copy link
Member

@luxas luxas commented Jul 19, 2016

@@ -0,0 +1,114 @@
Running Multi-Node Kubernetes Using Docker
Copy link

@johndmulhausen johndmulhausen Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file must open with these lines:

1: ---
2: ---

Do not put the title -- that will be pulled in from guides.yml

@luxas luxas force-pushed the fix_docker_multinode branch from 4d022c6 to 696c4ed Compare July 22, 2016 21:52
@luxas luxas assigned johndmulhausen and unassigned mikedanese Jul 22, 2016
@luxas
Copy link
Member Author

luxas commented Jul 22, 2016

@johndmulhausen Updated

@luxas
Copy link
Member Author

luxas commented Jul 28, 2016

@mikedanese Ping

Also cc @kelseyhightower if you have time :)

## Overview

This guide will set up a 2-node Kubernetes cluster, consisting of a _master_ node which hosts the API server and orchestrates work
and a _worker_ node which receives work from the master. You can repeat the process of adding worker nodes an arbitrary number of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better or worse we have settled on using the terms "master" and "node". It's confusing to keep using worker and minion in documentation.

@mikedanese
Copy link
Member

Please address comment in a follow up. @pwittrock this LGTM

@luxas
Copy link
Member Author

luxas commented Aug 2, 2016

Is it ok for me to merge this now?

I fixed @johndmulhausen's comments and @mikedanese LGTM'd it
I'll fix nits in follow-ups

@mikedanese mikedanese merged commit fc196ff into kubernetes:master Aug 2, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Feb 24, 2021
- General wordsmithing and content updates
- Remove manual schema (we can't maintain this this way)

Signed-off-by: William Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants