Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster-management.md #581

Merged
merged 2 commits into from
Jul 28, 2016
Merged

Update cluster-management.md #581

merged 2 commits into from
Jul 28, 2016

Conversation

ghodss
Copy link
Contributor

@ghodss ghodss commented May 26, 2016

Update node maintenance to include the current kubectl commands.

Update node maintenance to include the current kubectl commands.
For pods with a replication controller, the pod will eventually be replaced by a new pod which will be scheduled to a new node. Additionally, if the pod is part of a service, then clients will automatically be redirected to the new pod.

For pods with no replication controller, you need to bring up a new copy of the pod, and assuming it is not part of a service, redirect clients to it.
For pods with no replica set, you need to bring up a new copy of the pod, and assuming it is not part of a service, redirect clients to it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you just delete the instructions to do this (for replication controllers)? It's best if we don't leave people with a set of vague instructions and not tell them how to handle it, specifically. These are docs, not tweets. :) At a minimum, link to instructions, but if possible, restore applicable instructions that this PR deletes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe there were any instructions here (before my PR) that explain how to "bring up a new copy of the pod" for pods with no replication controller. I only deleted the instructions for deleting existing pods, and I deleted those because kubectl drain, the new command I documented, already does that for you, so there's no need to do it yourself.

@kelseyhightower
Copy link
Contributor

LGTM. Thanks @ghodss!

@kelseyhightower kelseyhightower merged commit 6bed6f4 into master Jul 28, 2016
@janetkuo janetkuo deleted the ghodss-patch-1 branch September 1, 2016 17:39
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Feb 24, 2021
dims pushed a commit to dims/website that referenced this pull request Jan 23, 2023
update build command from source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants