-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cluster-management.md #581
Conversation
Update node maintenance to include the current kubectl commands.
For pods with a replication controller, the pod will eventually be replaced by a new pod which will be scheduled to a new node. Additionally, if the pod is part of a service, then clients will automatically be redirected to the new pod. | ||
|
||
For pods with no replication controller, you need to bring up a new copy of the pod, and assuming it is not part of a service, redirect clients to it. | ||
For pods with no replica set, you need to bring up a new copy of the pod, and assuming it is not part of a service, redirect clients to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you just delete the instructions to do this (for replication controllers)? It's best if we don't leave people with a set of vague instructions and not tell them how to handle it, specifically. These are docs, not tweets. :) At a minimum, link to instructions, but if possible, restore applicable instructions that this PR deletes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not believe there were any instructions here (before my PR) that explain how to "bring up a new copy of the pod" for pods with no replication controller. I only deleted the instructions for deleting existing pods, and I deleted those because kubectl drain
, the new command I documented, already does that for you, so there's no need to do it yourself.
LGTM. Thanks @ghodss! |
Signed-off-by: Ivan Sim <[email protected]>
update build command from source
Update node maintenance to include the current kubectl commands.