Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark HonorPVReclaimPolicy as stable #49405

Merged
merged 1 commit into from
Feb 28, 2025
Merged

mark HonorPVReclaimPolicy as stable #49405

merged 1 commit into from
Feb 28, 2025

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 13, 2025

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 13, 2025
@carlory
Copy link
Member Author

carlory commented Jan 13, 2025

/cc @deepakkinni @xing-yang

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e8eb812
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/679ed7eb358bae00081ea8f0

@carlory
Copy link
Member Author

carlory commented Jan 13, 2025

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 13, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e8eb812
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679ed7ebeec12a0008b51ff2
😎 Deploy Preview https://deploy-preview-49405--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@carlory carlory force-pushed the HonorPVReclaimPolicy branch from 0c1153a to e8eb812 Compare February 2, 2025 02:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2025
@Shubham82
Copy link
Contributor

Thanks @carlory
/lgtm

unhold it, when Upstream PR merges.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d64143b56c6e25b5c7fde9f11d1ab0c65cef2d3e

@carlory
Copy link
Member Author

carlory commented Feb 28, 2025

/hold cancel
/assign @rayandas
for approval

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
@rayandas
Copy link
Member

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayandas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit bd06a20 into kubernetes:dev-1.33 Feb 28, 2025
6 checks passed
@carlory carlory deleted the HonorPVReclaimPolicy branch February 28, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@tengqm tengqm Awaiting requested review from tengqm

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@rayandas rayandas

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlory @Shubham82 @k8s-ci-robot @rayandas