Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.25 api reference multi pages #35676

Merged

Conversation

feloy
Copy link
Member

@feloy feloy commented Aug 3, 2022

Update of API Reference multi-pages (https://kubernetes.io/docs/reference/kubernetes-api/) for v1.25

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d330f97
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62ffaf2539fc4100087f21b1

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from onlydole and sftim August 3, 2022 16:14
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 3, 2022
@reylejano
Copy link
Member

/milestone 1.25
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot requested a review from kcmartin August 3, 2022 22:14
@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 3, 2022
@kcmartin
Copy link
Contributor

@feloy -- There are some unaddressed comments from @sftim above -- we are past the deadline for 1.25 docs, can you get the changes in ASAP, please??

@sftim
Copy link
Contributor

sftim commented Aug 10, 2022

Actually, the deadline for these docs is basically release day.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2022
@feloy feloy force-pushed the v1.25-api-reference-multi-pages branch from 4796dd9 to d330f97 Compare August 19, 2022 15:41
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2022
@reylejano
Copy link
Member

Thank you for generating the API reference docs
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
Copy link
Contributor

@kcmartin kcmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: af1556419213a4b6e056b17ff44221520ca6ca89

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kcmartin, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0cf0e54 into kubernetes:dev-1.25 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants