-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'Seccomp defaulting' feature name #35121
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout! It does make it clearer for the reader.
/lgtm
LGTM label has been added. Git tree hash: e41ab89e2948f61b2c8cf0e79b3e3dcceb7b53be
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as possible, we should write the docs as if the feature is already GA. We still need to mention the name of the related feature gate until graduation to stable, but we should try to minimize those mentions.
Writing as if the feature is stable makes it easier to adapt at graduation time, and helps makes those docs closer to our timeless docs ideal.
I'm not going to /lgtm cancel this, but I do disagree with exposing the feature gate name as jargon that we expect readers to recognize. |
I think this may be an exception to the rule, given that this functionality is transitional by nature and will become a non-feature as soon as it GAs. Given the security implications of assuming this is enabled when it may not be, I also don't think the timeless docs approach should apply, or we risk leaving users that potentially don't know the ins and outs of Seccomp worse off. But I am keen to hear what other folks may think about this. |
I don't understand that, to be honest.
|
Seccomp defaulting for Pods is a beta feature in Kubernetes {{< skew currentVersion >}}, | ||
SeccompDefault for Pods is a beta feature in Kubernetes {{< skew currentVersion >}}, | ||
and the corresponding `SeccompDefault` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) | ||
is enabled by default. However, you still need to enable this defaulting for each node where | ||
you would like to use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like:
Kubernetes {{< skew currentVersion >}} lets you configure the seccomp profile that applies when the
spec for a Pod doesn't define a specific seccomp profile. This is a beta feature and …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, thank you for the input. I changed the paragraphs a bit.
We're now rephrasing those two paragraphs to avoid confusing readers. Signed-off-by: Sascha Grunert <[email protected]>
SeccompDefault
feature nameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
LGTM label has been added. Git tree hash: 77a127835ffb589f0c4dd2603e54fc131235c940
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pjbgf, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I didn't notice that this targeted dev-1.25. It's fine, but we could actually have targeted main here. Also OK to |
Changing it in |
Git can automatically solve a merge if we cherry pick these exact changes. |
We're now rephrasing those two paragraphs to avoid confusing readers.
Follow-up on #34640 (comment)