Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the deprecated kubernetes.io/psp annotation #34675

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Document the deprecated kubernetes.io/psp annotation #34675

merged 7 commits into from
Jul 25, 2022

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jun 28, 2022

Solves #30578 according to that comment #30578 (comment).

I took the liberty to change a command in the tutorial as well because I added a step to check that annotation.

- kubectl-admin create -f example-psp.yaml
+ kubectl-admin create -f https://k8s.io/examples/policy/example-psp.yaml

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 28, 2022
@netlify
Copy link

netlify bot commented Jun 28, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1d55061
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62bc0183ba6f0b0009810703
😎 Deploy Preview https://deploy-preview-34675--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

I have a few suggestions if you want to tweak this further.

content/en/docs/concepts/security/pod-security-policy.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-policy.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 79a75e511aef4652ee0ccf9bd7cfb7bbaea07cea

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 29, 2022 07:26
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2022
sftim
sftim reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8066bfb0ce5c52924149d60397058869b32fcab

@sftim sftim mentioned this pull request Jun 29, 2022
Merged
@mehabhalodiya
Copy link
Contributor

/lgtm

divya-mohan0209
divya-mohan0209 reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Mahé!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 54d2e71 into kubernetes:main Jul 25, 2022
@mtardy mtardy deleted the psp-annotation branch July 25, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@pweil- pweil- Awaiting requested review from pweil-

Assignees

@sftim sftim

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtardy @k8s-ci-robot @mehabhalodiya @divya-mohan0209 @sftim