-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features: add ContextualLogging #32452
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
/hold Code PRs needs to be merged first. |
use the [corresponding logging | ||
calls](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging#feature-gate). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any documentation on https://k8s.dev/ about contextual logging? Ideally, we'd make sure that there was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, because it currently doesn't make a difference for end-users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See content/en/docs/concepts/cluster-administration/system-logs.md for an explanation based on the example command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, wrong site. For developers I have kubernetes/community#6560 pending. Should that document be moved to k8s.dev?
@pohly maybe what we should try to document is the format of logs when you select This feature gate is something we could mention on the page that describes that format, I think? |
/sig instrumentation |
/assign @chrisnegus |
The feature is independent of the output format. |
Imagine a new reference page titled “Logging Output” or “Logging Formats”. Could we mention in that page the effect that this feature gate has on what output you get? |
Right now: none 😅 I could make something up, but that doesn't seem useful. First some Kubernetes components must use the new infrastructure to extend their log output. kube-scheduler is likely to be the first candidate, but given that the infrastructure is going in late in the 1.24 cycle, those changes are probably not going to make the cut. |
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
I remembered that I had extended the logging example so that it does contextual logging and has the |
This is a new feature in 1.24. Only the infrastructure is going in at this point with no changes in Kubernetes components, so the user-visible effect is minimal.
825765d
to
4a57c11
Compare
/hold cancel Code PRs were merged, this can get included in the 1.24 documentation now. I've also extended system-logs.md with information about the feature. |
enhancement ref: kubernetes/enhancements#3077 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d241ecaf57cefcc9e6b6786b3ead4a25c002d72d
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a new feature in 1.24. Only the infrastructure is going in at this
point with no changes in Kubernetes components, so the user-visible effect is
minimal.