-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax errors #27735
Fix syntax errors #27735
Conversation
smuu
commented
Apr 26, 2021
- fix wrong placed line breaks
- fix command mode start and end
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @smuu! |
- fix wrong placed line breaks - fix command mode start and end
Deploy preview for kubernetes-io-master-staging ready! Built with commit 57132e0 https://deploy-preview-27735--kubernetes-io-master-staging.netlify.app |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 295277b https://deploy-preview-27735--kubernetes-io-master-staging.netlify.app |
Signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested edit per SG.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
How about having some markdown lint checker as a CI job? /cc @oomichi |
I like that idea. I just run markdownlint locally and I got over 130.000 hits (excluded the sub-modules in the repository) and over 81.000 hits when I ignore |
Hehe, I don't think that is just a bit :) /lgtm |
LGTM label has been added. Git tree hash: f10840820293d6170ac5a18f284efcec7fe22674
|
Thanks @smuu . |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |