Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise blog article “Annotating Kubernetes for humans” #27628

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Apr 20, 2021

Tweaks to https://kubernetes.io/blog/2021/04/20/annotating-k8s-for-humans/

Aimed at avoiding full removal per #27625, by just excising problematic content (commercial links etc).

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 20, 2021
@sftim sftim force-pushed the 20210420_revise_blog_2021-04-20_annotating-k8s-for-humans.md branch 2 times, most recently from 482cd59 to db37dbc Compare April 20, 2021 11:46
- Tweak capitalization etc
- Remove links to commercial services
@sftim sftim force-pushed the 20210420_revise_blog_2021-04-20_annotating-k8s-for-humans.md branch from db37dbc to fc66195 Compare April 20, 2021 11:46
@sftim sftim marked this pull request as ready for review April 20, 2021 11:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2021
@mrbobbytables
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 27e6df24a665e3605fbd1cbc80597436f3db6b68

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@netlify
Copy link

netlify bot commented Apr 20, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a4ffde3

https://deploy-preview-27628--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented Apr 20, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit fc66195

https://deploy-preview-27628--kubernetes-io-master-staging.netlify.app

@k8s-ci-robot k8s-ci-robot merged commit fb86b14 into kubernetes:master Apr 20, 2021
@sftim sftim deleted the 20210420_revise_blog_2021-04-20_annotating-k8s-for-humans.md branch June 9, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants