Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors #27565, #27569 #27577

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix errors #27565, #27569 #27577

merged 1 commit into from
Apr 19, 2021

Conversation

jihoon-seo
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 16, 2021
@netlify
Copy link

netlify bot commented Apr 16, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3100379

https://deploy-preview-27577--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

kbhawkey commented Apr 19, 2021 •
edited
Loading

/kind cleanup

Page preview:
https://deploy-preview-27577--kubernetes-io-master-staging.netlify.app/docs/reference/labels-annotations-taints/
https://deploy-preview-27577--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 19, 2021
@kbhawkey
Copy link
Contributor

Thanks @jihoon-seo .
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5561b99c770379290b32c168685e548f52b9083e

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@jihoon-seo
Copy link
Member Author

I found another error in content/en/docs/reference/labels-annotations-taints.md.

[As-is]

[Pod Deletion Cost](/docs/content/en/docs/concepts/workloads/controllers/replicaset/#pod-deletion-cost)

[To-be]

[Pod Deletion Cost](/docs/concepts/workloads/controllers/replicaset/#pod-deletion-cost)

PTAL again after my commit, squash, and force-push.
Thanks!

@jihoon-seo jihoon-seo force-pushed the 210416_Fix_errors_27565_27569 branch from ba6f93a to 3100379 Compare April 19, 2021 02:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@nate-double-u
Copy link
Contributor

New preview list:

Links checked
Redirect works

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d67232051ff1e0cca4ab443bc379493ba0a8cb8b

@kbhawkey
Copy link
Contributor

Thanks @jihoon-seo .
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9b6bba4 into kubernetes:master Apr 19, 2021
@jihoon-seo jihoon-seo deleted the 210416_Fix_errors_27565_27569 branch April 19, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@castrojo castrojo Awaiting requested review from castrojo

Assignees

@kbhawkey kbhawkey

@nate-double-u nate-double-u

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@jihoon-seo @kbhawkey @k8s-ci-robot @nate-double-u