Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"*-controller-manager" typo fix #27559

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

bridgetkromhout
Copy link
Member

I noticed a typo in a recent blog post, and a similar typo appears in
the comments for some examples. This PR corrects these typos.

I see https://kubernetes.io/docs/contribute/new-content/overview/#languages-per-pr but I'm not sure if it applies since I'm changing English-language comments. If this needs to be PRed separately regardless of not needing language-specific review, please let me know. Thanks!

Signed-off-by: Bridget Kromhout [email protected]

I noticed a typo in a recent blog post, and a similar typo appears in
the comments for some examples. This PR corrects these typos.

Signed-off-by: Bridget Kromhout <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Apr 14, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2021
@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f7a0a0a

https://deploy-preview-27559--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

/cc @kubernetes/sig-docs-ja-reviews @kubernetes/sig-docs-zh-reviews

@kbhawkey
Copy link
Contributor

Changes look good. Thanks @bridgetkromhout .
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0329c9a5b57bbdd503b7049cd76b9e60c4baf86e

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2021
@tengqm
Copy link
Contributor

tengqm commented Apr 15, 2021

/lgtm
for Chinese fix.

@sftim
Copy link
Contributor

sftim commented Apr 15, 2021

/approve

I hope this isn't too much of a merge problem for other localizations (the concern with languages per PR is mainly about the work for localization teams to manually resolve conflicts on their WIP branches)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 85d9573 into kubernetes:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants