Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API blog post - 04-22-2021 #27558

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Gateway API blog post - 04-22-2021 #27558

merged 1 commit into from
Apr 20, 2021

Conversation

mark-church
Copy link
Contributor

This is a blog post that summarizes the Gateway API specification. There are a number of vendors and users that have been contributing to the Gateway API design for over a year now. Since it is now in v1alpha1 and there are also a few implementations already available, we wanted to bring more visibility to the project before Kubecon. It doesn't look like 4/22/2021 is taken yet for a blog post so it would be great if we could get this slot for the post. This blog post was already discussed in the Gateway API repo at kubernetes-sigs/gateway-api#604

Thanks!

/area blog
/sig network

cc @mrbobbytables @bowei @robscott @hbagdi @danehans @stevesloka @SantoDE @yuval-k @thockin

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @mark-church!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 14, 2021
@stevesloka
Copy link
Contributor

fyi @youngnick

@netlify
Copy link

netlify bot commented Apr 14, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 81ad8e2

https://deploy-preview-27558--kubernetes-io-master-staging.netlify.app

mrbobbytables
mrbobbytables requested changes Apr 14, 2021
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall solid :)
A few small things like fixing image links, but other than that should be good to go 👍

SantoDE
SantoDE suggested changes Apr 15, 2021
View reviewed changes
Copy link

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot one minor nitpick. Sorry :)

sftim
sftim reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback - I hope it makes sense and is useful.

hbagdi
hbagdi reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Nice work, Mark!

youngnick
youngnick reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions from me, but this looks great, thanks @mark-church!

@mark-church
Copy link
Contributor Author

@mrbobbytables I updated the links as you suggested but it looks like the images are still not working in the latest netlify preview. Do I need to update the folder structure for this PR? It looks like the staging site is using the folder /blog/2021/04/22/evolving-kubernetes-networking-with-the-gateway-api/.

mrbobbytables
mrbobbytables approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good to me!
Thanks @mark-church! :)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@castrojo
Copy link
Member

/lgtm

Thanks everyone, this one was a great read!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de7c52b95f3fcf60626fca1949261a8bfce15d9b

@k8s-ci-robot k8s-ci-robot merged commit d5f3d74 into kubernetes:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi left review comments

@youngnick youngnick youngnick left review comments

@sftim sftim sftim left review comments

@SantoDE SantoDE SantoDE requested changes

@mrbobbytables mrbobbytables mrbobbytables approved these changes

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@castrojo castrojo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mark-church @k8s-ci-robot @stevesloka @castrojo @SantoDE @hbagdi @mrbobbytables @youngnick @sftim