Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics stability to GA blog post #27359

Merged
merged 8 commits into from
Apr 19, 2021
Merged

metrics stability to GA blog post #27359

merged 8 commits into from
Apr 19, 2021

Conversation

logicalhan
Copy link
Member

Add blog post announcement for metrics stability framework to GA in v1.21 and the various support guarantees they have depending on the stability level of a metric.

/hold

/cc @ehashman

@k8s-ci-robot k8s-ci-robot requested a review from ehashman March 31, 2021 13:08
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 31, 2021
@logicalhan
Copy link
Member Author

/assign @Pensu

@netlify
Copy link

netlify bot commented Mar 31, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit fcbe5a7

https://deploy-preview-27359--kubernetes-io-master-staging.netlify.app

@divya-mohan0209
Copy link
Contributor

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Mar 31, 2021
sftim
sftim reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to propose this article for https://k8s.dev/blog/ - we'll semi-automagically mirror that article into the main Kubernetes blog anyway, we do that for all https://k8s.dev/blog/ articles at the moment.

I also made some inline suggestions.

@logicalhan
Copy link
Member Author

You might want to propose this article for https://k8s.dev/blog/ - we'll semi-automagically mirror that article into the main Kubernetes blog anyway, we do that for all https://k8s.dev/blog/ articles at the moment.

I also made some inline suggestions.

How do I go about doing that?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2021
@sftim
Copy link
Contributor

sftim commented Apr 3, 2021

To propose a blog article for https://k8s.dev/blog, send a PR to https://github.com/kubernetes/contributor-site (it's pretty similar to this site, they both use Hugo with the Docsy theme and they both publish using Netlify).

Han Kang and others added 2 commits April 5, 2021 12:41
@mrbobbytables
Update content/en/blog/_posts/2021-03-30-metrics-stability-ga/2021-03…
1b29725 
…-30-metrics-stability-hits-ga.md

Co-authored-by: Bob Killen <[email protected]>
@mrbobbytables mrbobbytables added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 18, 2021
@mrbobbytables
Copy link
Member

This is both a user and contributor facing change, and mirroring on both would be good BUT I don't want to throw off the release blog schedule, so I think we can publish here and do a follow up PR to add the link once its posted over there too.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2021
@logicalhan
Copy link
Member Author

@mrbobbytables should i remove the hold?

@sftim
Copy link
Contributor

sftim commented Apr 19, 2021

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: adf1537eed7252707907452539c2f8c2c5d92463

@k8s-ci-robot k8s-ci-robot merged commit 371c74a into kubernetes:master Apr 19, 2021
@logicalhan
Copy link
Member Author

thanks @sftim!

ehashman
ehashman reviewed Apr 19, 2021
View reviewed changes
content/en/blog/_posts/2021-04-23-metrics-stability-ga/2021-04-23-metrics-stability-hits-ga.md
---
layout: blog
title: 'Kubernetes 1.21: Metrics Stability hits GA'
date: 2021-04-23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not go live until Friday then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, theres a cronjob that runs twice daily (IIRC) that will rebuild the site each day. Hugo won't build future dated blog posts \o/ Makes it a lot easier than having to manage holds like we used to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! Looking forward to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@mrbobbytables mrbobbytables mrbobbytables left review comments

@sftim sftim sftim left review comments

Assignees

@Pensu Pensu

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@logicalhan @divya-mohan0209 @sftim @mrbobbytables @k8s-ci-robot @ehashman @Pensu