Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate docs/tasks/configmap-secret/managing-secret-using-config-file/ into Japanese #27065

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Translate docs/tasks/configmap-secret/managing-secret-using-config-file/ into Japanese #27065

merged 3 commits into from
Apr 20, 2021

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Mar 15, 2021

closes #27064

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2021
@netlify
Copy link

netlify bot commented Mar 15, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 04c41cb

https://deploy-preview-27065--kubernetes-io-master-staging.netlify.app

@oke-py
Copy link
Contributor Author

oke-py commented Mar 15, 2021

https://deploy-preview-27065--kubernetes-io-master-staging.netlify.app/ja/docs/tasks/configmap-secret/managing-secret-using-config-file/

@oke-py
Copy link
Contributor Author

oke-py commented Mar 15, 2021

/assign @nasa9084

YuikoTakada
YuikoTakada reviewed Mar 16, 2021
View reviewed changes
content/ja/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated

## 設定ファイルを作成する

先にJSONやYAML形式のファイルでSecretを作成してから、そのオブジェクトを作成することができます。
Copy link
Contributor

@YuikoTakada YuikoTakada Mar 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

あらかじめJSONやYAML形式のファイルを作成することで、Secretを作成することができます。

?

Copy link
Member

@inductor inductor Mar 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuikoTakada I think することで implies a way to do something.「あらかじめJSONやYAML形式のファイルを作成」only says that you can create a YAML/JSON file, which does not mean you can create an actual object, so I would leave it as 「してから」 rather than using 「することで」, because 作成することで～できます sounds like you can create the object just by creating the YAML/JSON file which is not true.

What about something like this

あらかじめYAMLまたはJSON形式でSecretのマニフェストを作成したうえで、オブジェクトを作成することができます。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inductor thank you for your comments.

あらかじめYAMLまたはJSON形式でSecretのマニフェストを作成したうえで、オブジェクトを作成することができます。

It sounds good, thanks.

YuikoTakada
YuikoTakada reviewed Mar 17, 2021
View reviewed changes
content/ja/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated

{{< note >}}
SecretデータのシリアライズされたJSONおよびYAMLの値は、base64文字列としてエンコードされます。
これらの文字列の中では、改行は有効ではなく、省略する必要があります。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in https://kubernetes.io/ja/docs/concepts/configuration/secret/ , written as:

シリアライズされたJSONやYAMLの機密データはBase64エンコードされています。 
文字列の中の改行は不正で、含まれていてはなりません。

I myself prefer Secretデータ rather than 機密データ so I love your translation, but I think 不正な is better than 有効でなく . so I suggest:

SecretデータのシリアライズされたJSONおよびYAMLの値は、base64文字列としてエンコードされます。
文字列の中の改行は不正で、含まれていてはなりません。

How do you thinnk?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd write 文字列中 instead because の~の sounds a bit lengthy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inductor thank you for your comments.
you mean, you prefer 文字列中の改行は不正で、 instead of 文字列の中の改行は不正で、 , right?
it sounds good :)

@YuikoTakada
Copy link
Contributor

Thank you for your PR. I wrote one more comments, so please check it.

@oke-py oke-py requested a review from YuikoTakada March 17, 2021 11:28
@oke-py
Copy link
Contributor Author

oke-py commented Mar 17, 2021

Thanks for your review. I applied suggestion.

@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@inductor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b6f485e99aef679d9240a652bac9fc09c17ed52

@k8s-ci-robot k8s-ci-robot merged commit 9c854c6 into kubernetes:master Apr 20, 2021
@oke-py oke-py deleted the 27064 branch April 20, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inductor inductor Awaiting requested review from inductor

@makocchi-git makocchi-git Awaiting requested review from makocchi-git

@YuikoTakada YuikoTakada Awaiting requested review from YuikoTakada

Assignees

@nasa9084 nasa9084

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate docs/tasks/configmap-secret/managing-secret-using-config-file/ into Japanese
5 participants
@oke-py @YuikoTakada @nasa9084 @k8s-ci-robot @inductor