Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy EndpointSlice concept #22529

Merged

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jul 15, 2020

/kind cleanup

Tidy https://k8s.io/docs/concepts/services-networking/endpoint-slices/ on top of the changes for v1.19 [preview]

One overall theme is to describe what that control plane does rather than the specific controllers. In my view, that level of detail is best left for the Reference section (I started work to add details of all the built-in control loops there in PR #16885, and one day I might pick that up again). Many people who need to understand how Kubernetes works don't need to look inside the control plane, they can just treat it as an opaque box fronted by the API.

Following on from PR #20072 this also moves EndpointSlice down in the section by giving it a higher weight.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jul 15, 2020

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 591d3c1

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0ece2b8fe82d0007ac028a

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2020
@sftim sftim requested a review from robscott July 15, 2020 09:16
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 15, 2020
@sftim sftim force-pushed the 20200715_tidy_endpointslice_concept branch from 46e2692 to 591d3c1 Compare July 15, 2020 09:36
@celestehorgan
Copy link
Contributor

/lgtm

Thanks for this quiet, persistent content work @sftim :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, @sftim! Thank you for the help on this one.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: onlydole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 38b7408 into kubernetes:dev-1.19 Jul 15, 2020
@sftim sftim deleted the 20200715_tidy_endpointslice_concept branch July 16, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants