-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy EndpointSlice concept #22529
Tidy EndpointSlice concept #22529
Conversation
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 591d3c1 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0ece2b8fe82d0007ac028a |
46e2692
to
591d3c1
Compare
/lgtm Thanks for this quiet, persistent content work @sftim :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, @sftim! Thank you for the help on this one.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: onlydole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup
Tidy https://k8s.io/docs/concepts/services-networking/endpoint-slices/ on top of the changes for v1.19 [preview]
One overall theme is to describe what that control plane does rather than the specific controllers. In my view, that level of detail is best left for the Reference section (I started work to add details of all the built-in control loops there in PR #16885, and one day I might pick that up again). Many people who need to understand how Kubernetes works don't need to look inside the control plane, they can just treat it as an opaque box fronted by the API.
Following on from PR #20072 this also moves EndpointSlice down in the section by giving it a higher weight.