Typo - The example code doesn't match to the explantation.

[cainzhong]

No description provided.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @cainzhong!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign daminisatya
You can assign the PR to them by writing /assign @daminisatya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3d9f527

https://deploy-preview-19186--kubernetes-io-master-staging.netlify.com

[RA489]

/check-cla

[cainzhong]

/assign @daminisatya

[sftim]

Looks like this was wrong in commit e26aa12 (from #1196) and since then. The correction looks fine to me.

@derekwaynecarr would you be willing to check that this fix is correct? It's OK to decline.

[sftim]

Actually, looking again, I think the original text is correct. The example made me realize that you need to sum each set of thresholds to work out where resource pressure is first detected.

[sftim]

@cainzhong I think it'd make more sense to revise the page text to clarify the summing, but leave the commands untouched. What do you think?

[sftim]

/assign

[cainzhong]

Actually, looking again, I think the original text is correct. The example made me realize that you need to sum each set of thresholds to work out where resource pressure is first detected.

Sorry. I don't understand. What do you mean 'sum each set of thresholds to work out where resource pressure is first detected.'?

[sftim]

Let's focus on imagefs.available.
--eviction-hard in the example sets imagefs.available<100Gi
--eviction-minimum-reclaim sets imagefs.available=2Gi

the kubelet works to ensure that imagefs.available is at least 102Gi. 100 + 2 = 102.

[sftim]

@cainzhong - whilst the original page is hard to understand, I don't think this change is correct.
/close

[k8s-ci-robot]

@sftim: Closed this PR.

In response to this:

@cainzhong - whilst the original page is hard to understand, I don't think this change is correct.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cainzhong]

@cainzhong - whilst the original page is hard to understand, I don't think this change is correct.
/close

Do not agree with you. Let's just focus on the typo issue, do you agree it is a typo?
If you think the original page is hard to understand, I think it is another issue.

[cainzhong]

/Reopen

[k8s-ci-robot]

@cainzhong: Reopened this PR.

In response to this:

/Reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sftim]

Hi @cainzhong

I don't see any typo on the existing page. Did the maths at #19186 (comment) make sense to you?

[cainzhong]

hi @sftim
Finally, I understand the code mean. It should do a math operation addition.
Thanks.