Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cloudprovider link error #12539

Merged
merged 1 commit into from
Feb 8, 2019
Merged

fix cloudprovider link error #12539

merged 1 commit into from
Feb 8, 2019

Conversation

hello2mao
Copy link
Contributor

What this PR does / why we need it:
Fix cloudprovider.Interface link error.
The old one is 404(not found).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from luxas and wlan0 February 7, 2019 14:23
@netlify
Copy link

netlify bot commented Feb 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a29241b

https://deploy-preview-12539--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

Thanks for the update @hello2mao !!!
/lgtm

I checked the preview here: https://deploy-preview-12539--kubernetes-io-master-staging.netlify.com/docs/tasks/administer-cluster/developing-cloud-controller-manager/

/assign @zparnold

Please take a look and state your approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
@Rajakavitha1
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit b3bfb4d into kubernetes:master Feb 8, 2019
@hello2mao hello2mao mentioned this pull request Feb 14, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas Awaiting requested review from luxas

@wlan0 wlan0 Awaiting requested review from wlan0

Assignees

@zparnold zparnold

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hello2mao @Rajakavitha1 @k8s-ci-robot @zparnold