-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubelet --feature-gates and add --rotate-server-certificates #12332
Conversation
oke-py
commented
Jan 23, 2019
- Update kubelet --feature-gates referring to this file
- some features promoted to Beta/GA
- some features deprecated and removed
- Accelerators Deprecate the alpha Accelerators feature gate. kubernetes#57384
- KubeletConfigFile Removal of KubeletConfigFile feature gate: Step 3 (final) kubernetes#58978
- ReadOnlyAPIDataVolumes Remove deprecated feature flags kubernetes#67951
- ServiceProxyAllowExternalIPs Remove deprecated feature flags kubernetes#67951
- Add kubelet --rotate-server-certificates
- description derives from this line
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit d8679c7 https://deploy-preview-12332--kubernetes-io-master-staging.netlify.com |
Hi @oke-py, thanks for the PR. Did you manually edit this file or generate it? This file is a generated file, so if you manually edited it, your changes will be overwritten the next time it is generated. |
@tfogo Oh, I edited this file manually. Is there anything I can do? |
/assign @ryanmcginnis |
i don't have enough understanding of the repo to know how to make changes to an autogenerated file... i've reassigned this PR to mistyhacks@ assuming she might know. |
@zparnold Please take a look. |
@zparnold: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |