Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent to send all files to docker daemon #10129

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

superbrothers
Copy link
Member

This PR prevents to send all files to docker daemon in order to build kubernetes-hugo image.

Currently, all files in this repository are sent to docker daemon when building kubernetes-hugo image. But they are not used in Dockerfile, so with this PR, I adds .dockerignore file to prevent to send all files to docker daemon.

Before

$ make docker-image
docker build . --tag kubernetes-hugo --build-arg HUGO_VERSION=0.47.1
Sending build context to Docker daemon    229MB
Step 1/7 : FROM alpine:latest
...

After

$ make docker-image
docker build . --tag kubernetes-hugo --build-arg HUGO_VERSION=0.47.1
Sending build context to Docker daemon  3.584kB
Step 1/7 : FROM alpine:latest
...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 166556d

https://deploy-preview-10129--kubernetes-io-master-staging.netlify.com

@Bradamant3
Copy link
Contributor

/assign @lucperkins

@lucperkins
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@superbrothers
Copy link
Member Author

/assign @Bradamant3

@Bradamant3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, lucperkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit c072b9b into kubernetes:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants