-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autobump prow images #34245
base: master
Are you sure you want to change the base?
Autobump prow images #34245
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danilo-gemoli The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these need to be kept in sync with the prow deployment? (which lives in k8s.io currently)
(or can we stop explicitly setting them and get a default from there?) |
I can't find anything referencing those images in $ grep -RP 'us\-docker\.pkg\.dev.*(clonerefs|initupload|entrypoint|sidecar)' src/github.com/kubernetes/k8s.io/ | wc -l
0 by the way, don't we already have an autobumper configured for it? Job here and config here. |
Not these images, but the overall prow ""release"", I'm not sure if prow supports skew between these images and the controllers that create modified pods using them. Those controllers are in the same staging registry and bumped together at once in k8s.io Previously the prow deployment was also in this repo so all of the images bumped together. cc @petr-muller @upodroid 👀 |
(Also, if prow had the ability to fallback to using the current release, then I think it would make more sense to stop explicitly configuring this across-repos, but I suspect it doesn't and that might be problematic until we have a real release host and not just staging anyhow) |
We should bump them together, the assumption was they were in the same repo but we split them up. |
Maybe we can write a frequent, auto-merged, autobump job that just copies the version from k/k8s.io to these particular images? A bit rube-goldberg but ... |
Though, even then, there might be some breaking change in prow that requires bumping them together and then we're in trouble ... Maybe we can pull that out to a seperate config ... |
(we might also want to do something about the lint presubmit taking twice as long as the unit tests in the case that we're autobumping here to match k/k8s.io https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/34245/pull-test-infra-verify-lint/1885347342421331968) |
Instruct the
generic-autobumper
to handle the Prow images inconfig/prow/config.yaml
.Most likely, what follows is the list of images that will periodically bumped: