Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autobump prow images #34245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danilo-gemoli
Copy link
Contributor

Instruct the generic-autobumper to handle the Prow images in config/prow/config.yaml.
Most likely, what follows is the list of images that will periodically bumped:

$ grep -nF 'docker.pkg.dev' config/prow/config.yaml
19:        clonerefs: "us-docker.pkg.dev/k8s-infra-prow/images/clonerefs:v20240802-66b115076"
20:        initupload: "us-docker.pkg.dev/k8s-infra-prow/images/initupload:v20240802-66b115076"
21:        entrypoint: "us-docker.pkg.dev/k8s-infra-prow/images/entrypoint:v20240802-66b115076"
22:        sidecar: "us-docker.pkg.dev/k8s-infra-prow/images/sidecar:v20240802-66b115076"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danilo-gemoli
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 31, 2025
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need to be kept in sync with the prow deployment? (which lives in k8s.io currently)

@BenTheElder
Copy link
Member

(or can we stop explicitly setting them and get a default from there?)

@danilo-gemoli
Copy link
Contributor Author

I can't find anything referencing those images in kubernetes/k8s.io:

$ grep -RP 'us\-docker\.pkg\.dev.*(clonerefs|initupload|entrypoint|sidecar)' src/github.com/kubernetes/k8s.io/ | wc -l
0

by the way, don't we already have an autobumper configured for it? Job here and config here.
Maybe I'm missing something.

@BenTheElder
Copy link
Member

I can't find anything referencing those images in kubernetes/k8s.io:

Not these images, but the overall prow ""release"", I'm not sure if prow supports skew between these images and the controllers that create modified pods using them. Those controllers are in the same staging registry and bumped together at once in k8s.io

Previously the prow deployment was also in this repo so all of the images bumped together.

cc @petr-muller @upodroid 👀

@BenTheElder
Copy link
Member

(Also, if prow had the ability to fallback to using the current release, then I think it would make more sense to stop explicitly configuring this across-repos, but I suspect it doesn't and that might be problematic until we have a real release host and not just staging anyhow)

@upodroid
Copy link
Member

upodroid commented Feb 3, 2025

We should bump them together, the assumption was they were in the same repo but we split them up.

@BenTheElder
Copy link
Member

We should bump them together, the assumption was they were in the same repo but we split them up.

Maybe we can write a frequent, auto-merged, autobump job that just copies the version from k/k8s.io to these particular images?

A bit rube-goldberg but ...

@BenTheElder
Copy link
Member

Though, even then, there might be some breaking change in prow that requires bumping them together and then we're in trouble ...

Maybe we can pull that out to a seperate config ...

@BenTheElder
Copy link
Member

(we might also want to do something about the lint presubmit taking twice as long as the unit tests in the case that we're autobumping here to match k/k8s.io https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/34245/pull-test-infra-verify-lint/1885347342421331968)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants