-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e etcd presubmit #31257
add e2e etcd presubmit #31257
Conversation
/lgtm Thanks for helping us with this, great to see so fast progress. My only concern is proper planning and coordination. Making sure that the end result helps etcd project and we don't have any loose ends. Answering questions like: Do we plan to replace all the workflows? Are we sure all workflows can be migrated or are there any missing features in prow (like arm64 nodes)? Do we support two separate CI? Or we should start removing duplicated workflows now? How and where do we document the new CI so contributors can adjust? @jmhbnz could you help with that? /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent progress, thanks for the help with this @upodroid.
My only concern is proper planning and coordination. Making sure that the end result helps etcd project and we don't have any loose ends.
Agree @serathius - We probably need a second iteration of a CI improvements umbrella issue to plan out the rest of the work and make sure we can communicate all the changes to the rest of the project and make sure everyone understands.
I will try to spend some time in the coming few days on planning and documenting.
/lgtm Thanks. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@upodroid: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'll open one to track all the integration work |
These jobs have been long running on the prow infrastructure by the work from the pull request kubernetes/test-infra#31257. By having them as required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
/cc @serathius @ahrtr
@etsrpl
The presubmit jobs I introduced in #31218 are stable now and I made them required now.
I also introduced an e2e presubmit for someone to fix the bugs in the ci-etcd-e2e-amd64 job.
https://testgrid.k8s.io/sig-etcd-periodics#ci-etcd-e2e-amd64