Turn off image prepulling for e2e scalability tests #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
wojtek-t
reviewed
Apr 26, 2017
| @@ -13,6 +13,8 @@ NUM_NODES=100 | |||
| ALLOWED_NOTREADY_NODES=1 | |||
| REGISTER_MASTER=true | |||
|
|
|||
| # Switch off image puller to workaround #44701 | |||
There was a problem hiding this comment.
You should go the same for othe jobs (e.g. gci-scalablity).
There was a problem hiding this comment.
Should I also disable it for 1.5/1.6-release and the non-cri scalability tests?
There was a problem hiding this comment.
Let's not touch previous releases (1.5, 1.6), but let's fix for all current ones.
There was a problem hiding this comment.
Done. I've changed it for all tests with (NUM_NODES >= 100 && ! previous release && ! gke && ! kubemark).
Because it doesn't affect our kubemark tests and for gke it appears like this prepuller is not mentioned anywhere in the config-(default/test),sh files.
shyamjvs
force-pushed
the
disable-image-prepull
branch
from
5ca117d to
3684880
Compare
shyamjvs
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref kubernetes/kubernetes#44701
Let's try out and see.
cc @kubernetes/sig-scalability-misc @wojtek-t @gmarek