Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: move cluster-api-provider-azure to main branch #23260

Merged
merged 1 commit into from
Aug 17, 2021
Merged

config/jobs: move cluster-api-provider-azure to main branch #23260

merged 1 commit into from
Aug 17, 2021

Conversation

mboersma
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mboersma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 16, 2021
@mboersma
Copy link
Contributor Author

/hold

This needs to be merged in conjunction with the actual branch renaming.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/config Issues or PRs related to code in /config area/jobs labels Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Aug 16, 2021
@mboersma mboersma mentioned this pull request Aug 16, 2021
Closed
19 tasks
CecileRobertMichon
CecileRobertMichon reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2021
CecileRobertMichon
CecileRobertMichon reviewed Aug 16, 2021
View reviewed changes
config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml
@@ -261,7 +261,7 @@ presubmits:
extra_refs:
- org: jackfrancis #TODO change back to kubernetes-sigs
repo: cluster-api-provider-azure
base_ref: capz-ha-control-plane-tests #TODO change back to master
base_ref: capz-ha-control-plane-tests #TODO change back to main

This comment was marked as off-topic.

Sign in to view

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will follow up on this later

CecileRobertMichon
CecileRobertMichon reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold until tomorrow when we do the rename

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@jsturtevant
Copy link
Contributor

Can we also include the Windows jobs. They merged today so might have been missed

test-infra/config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

Line 237 in 70d200d

- name: ci-kubernetes-e2e-capz-staging-dockershim-windows

test-infra/config/jobs/kubernetes-sigs/sig-windows/release-1.22-windows.yaml

Line 57 in e13b6b7

- name: ci-kubernetes-e2e-capz-azure-windows-dockershim-1-22

@mboersma mboersma force-pushed the azure-rename-branch-to-main branch from d512b8b to 0c534f0 Compare August 16, 2021 23:57
@mboersma
Copy link
Contributor Author

Updated for new Windows jobs, thanks for the eagle eyes @jsturtevant.

@CecileRobertMichon
Copy link
Member

/assign @jsturtevant for sig-windows jobs
/assign @dims @spiffxp (not sure how to assign on-call?) for image pushing job approval

/lgtm
for cloud-provider and capz jobs

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: GitHub didn't allow me to assign the following users: jobs, for, sig-windows.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jsturtevant for sig-windows jobs
/assign @dims @spiffxp (not sure how to assign on-call?) for image pushing job approval

/lgtm
for cloud-provider and capz jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@ameukam
Copy link
Member

ameukam commented Aug 17, 2021

/approve

@justaugustus
Copy link
Member

/lgtm
/approve

@jsturtevant
Copy link
Contributor

/lgtm

@jsturtevant
Copy link
Contributor

/approve

@CecileRobertMichon

This comment has been minimized.

Sign in to view
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, CecileRobertMichon, jsturtevant, justaugustus, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@CecileRobertMichon
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit e1343f2 into kubernetes:master Aug 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

@mboersma: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml
  • key k8s-staging-provider-azure.yaml using file config/jobs/image-pushing/k8s-staging-provider-azure.yaml
  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
  • key cluster-api-provider-azure-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-periodics.yaml
  • key release-1.22-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.22-windows.yaml
  • key release-master-windows-presubmits.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml
  • key release-master-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml
  • key release-1.19.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.19.yaml
  • key release-1.20.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.20.yaml
  • key release-1.21.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.21.yaml
  • key release-1.22.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.22.yaml
  • key release-master.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml

In response to this:

Refs kubernetes-sigs/cluster-api-provider-azure#749

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma deleted the azure-rename-branch-to-main branch August 17, 2021 18:29
@mboersma mboersma mentioned this pull request Aug 18, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant requested changes

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@justaugustus justaugustus

@jsturtevant jsturtevant

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@mboersma @k8s-ci-robot @jsturtevant @CecileRobertMichon @ameukam @justaugustus