Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurefile-csi-driver: add new prow job to test external e2e tests #22030

Merged

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Apr 30, 2021

with this kubernetes-sigs/azurefile-csi-driver#637 PR, azurefile-csi-driver introduces kubernetes external e2e tests. To tests the external e2e tests, we will require a new job.

thanks,
Manohar.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added area/jobs area/provider/azure Issues or PRs related to azure provider sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2021
@boddumanohar boddumanohar force-pushed the azurefile-csi--external-e2e branch from c05ad94 to 688f599 Compare April 30, 2021 09:41
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5b1cdbf into kubernetes:master Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

@boddumanohar: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key azurefile-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/azurefile-csi-driver/azurefile-csi-driver-config.yaml

In response to this:

with this kubernetes-sigs/azurefile-csi-driver#637 PR, azurefile-csi-driver introduces kubernetes external e2e tests. To tests the external e2e tests, we will require a new job.

thanks,
Manohar.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants