Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update integration jobs to use podutils and not kubekins-test #15156

Merged
merged 4 commits into from
Nov 7, 2019
Merged

update integration jobs to use podutils and not kubekins-test #15156

merged 4 commits into from
Nov 7, 2019

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 7, 2019
@cblecker
Copy link
Member

cblecker commented Nov 7, 2019

Other than one outstanding comment (#15156 (comment)) this LGTM

liggitt
liggitt reviewed Nov 7, 2019
View reviewed changes
config/jobs/kubernetes/sig-testing/integration.yaml
extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this get replaced as well with a fork-per-release?

@BenTheElder
Copy link
Member Author

sorry for the delay, fixed the image version. I swear something ate my changes :P

@cblecker
Copy link
Member

cblecker commented Nov 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a94035e into kubernetes:master Nov 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml

In response to this:

/cc @liggitt @cblecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt mentioned this pull request Nov 8, 2019
Merged
2 tasks
@liggitt liggitt mentioned this pull request Dec 18, 2019
Merged
@justaugustus justaugustus mentioned this pull request Dec 18, 2019
Closed
@liggitt liggitt mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@cblecker cblecker Awaiting requested review from cblecker

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @cblecker @k8s-ci-robot @liggitt