-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinct release bucket for federation ci jobs #146
Conversation
It seems that the build system will take care of creating the bucket. https://github.com/kubernetes/kubernetes/blob/master/build/common.sh#L1102 |
I dont know much about this code, but it LGTM. @spxtr ? |
@fejta @ixdy @kubernetes/sig-testing Could you please help me to get this PR merged ASAP. I don't seem to have the permissions required to assign/label etc within this test-infra repo. It is blocking e2e testing of Cluster Federation, which is in turn blocking the launch of v1.3. It resulted from a PR that merged late on Friday afternoon. For further details see: Thanks! cc: @nikhiljindal @madhusudancs @mml @matchstick FYI |
@quinton-hoole try again, see what perms you have... |
thanks @quinton-hoole for moving this one along! I still have no idea how we survived this long using the same bucket as "regular" kubernetes e2e... |
LGTM |
Thanks @eparis that did the trick. |
I'm not sure if anyone actually uses the labels though... I could be wrong... I think most people click the big green button... |
@eparis How do I make sure that this gets merged? There is no 1.3 milestone in this repo. Will merge-bot merge it automatically? If not, how do you suggest that we proceed? |
You should have the ability to push the big green button when travis is green @quinton-hoole. I'm considering just making kubernetes-maintainers have write permission over here too so I don't need to add people, but at the same time I like keeping them separate. |
Thanks @spxtr. Yes, I do have the permissions required to push the big green button. I just wanted to make sure that test-infra were happy with me performing a manual merge against this repo. |
@quinton-hoole everything outside the main repo is the 'wild wild west' |
Thanks for checking @quinton-hoole ! |
Mention feedback loop as future enhancement of Cluster Loader
Functions for reading and parsing discovery documents are moved to the "discovery" package and functions for converting between formats are moved to the "conversions" package.
Fixes #145
\cc @quinton-hoole @nikhiljindal @spxtr