Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable prometheus server in scalability tests #12394

Merged
merged 1 commit into from
May 6, 2019
Merged

Re-enable prometheus server in scalability tests #12394

merged 1 commit into from
May 6, 2019

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Apr 29, 2019

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from mborsz and shyamjvs April 29, 2019 11:46
@mm4tt
Copy link
Contributor Author

mm4tt commented Apr 29, 2019 •
edited
Loading

/hold

Cherrypicks to be merged: kubernetes/kubernetes#77117, kubernetes/kubernetes#77118

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2019
@mm4tt
Copy link
Contributor Author

mm4tt commented May 6, 2019

All cherrypicks have been merged

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2019
@mm4tt mm4tt changed the title WIP re-enable prometheus server in scalability tests Re-enable prometheus server in scalability tests May 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2019
@mm4tt
Copy link
Contributor Author

mm4tt commented May 6, 2019

/assign @wojtek-t

@wojtek-t
Copy link
Member

wojtek-t commented May 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bf66b4d4034e65e706bf1d842cc490295ea5704

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c810ba7 into kubernetes:master May 6, 2019
@k8s-ci-robot
Copy link
Contributor

@mm4tt: Updated the job-config configmap in namespace default using the following files:

  • key sig-scalability-presets.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml

In response to this:

All cherypicks have been merged: kubernetes/kubernetes#77117, kubernetes/kubernetes#77118, kubernetes/kubernetes#77119, kubernetes/kubernetes#77120.

Ref. kubernetes/kubernetes#73105

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shyamjvs shyamjvs mentioned this pull request May 7, 2019
Merged
@sttts
Copy link
Contributor

sttts commented May 9, 2019

Since this has been merged, gce-big is constantly failing in kubernetes/kubernetes#77207.

@mm4tt
Copy link
Contributor Author

mm4tt commented May 10, 2019

@sttts, looks like kubernetes/kubernetes#77207 eventually got merged. Is the problem still occurring? Let me know, if so, I can take a look.

@sttts
Copy link
Contributor

sttts commented May 10, 2019

@mm4tt looks like the issue was on our end. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mm4tt @wojtek-t @k8s-ci-robot @sttts