Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace incorrect github.com/golang/lint with actual golang.org/x/lint #11926

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Replace incorrect github.com/golang/lint with actual golang.org/x/lint #11926

merged 1 commit into from
Mar 25, 2019

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Mar 25, 2019

/assign @Katharine @cjwagner @michelle192837

This is still causing problems, https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-test-infra-autoupdate-minor/3:

go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"

For now just pinning this
ref golang/lint#436

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from ixdy and Katharine March 25, 2019 20:48
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
cjwagner
cjwagner approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/this-is-fine

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 365aaad852e6e312309e31d03fae6f4e3fe0c6a9

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2019
@k8s-ci-robot
Copy link
Contributor

@cjwagner: dog image

In response to this:

/lgtm
/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e0851f into kubernetes:master Mar 25, 2019
@fejta fejta deleted the minor branch March 25, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

@ixdy ixdy Awaiting requested review from ixdy

@Katharine Katharine Awaiting requested review from Katharine

Assignees

@Katharine Katharine

@michelle192837 michelle192837

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fejta @k8s-ci-robot @cjwagner @Katharine @michelle192837