Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tot with snowflake IDs #9604

Closed
krzyzacy opened this issue Sep 28, 2018 · 22 comments
Closed

Replace tot with snowflake IDs #9604

krzyzacy opened this issue Sep 28, 2018 · 22 comments
Assignees
Labels
area/gubernator Issues or PRs related to code in /gubernator area/kettle area/prow Issues or PRs related to prow area/testgrid priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@krzyzacy
Copy link
Member

ref #9593 (comment)

/area prow
cc @BenTheElder @cjwagner @spiffxp

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Sep 28, 2018
@spiffxp
Copy link
Member

spiffxp commented Sep 28, 2018

/area gubernator
Might have some impact here?

/area kettle
We would definitely want to revisit kettle's impl

/area testgrid
I don't know if this would impact testgrid at all, maybe during transition?

@BenTheElder
Copy link
Member

testgrid should be unimpacted unless we decide to go back, going back would be problematic. gubernator otoh reads latest-build.txt and would be fine.

@krzyzacy krzyzacy added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 10, 2018
@ixdy
Copy link
Member

ixdy commented Oct 24, 2018

/assign @fejta @BenTheElder
cc @Katharine to fix gubernator
cc @michelle192837 to fix testgrid and kettle

@BenTheElder
Copy link
Member

I think testgrid already works fine? not sure about kettle cc @spiffxp
Gubernator will need fixing or we'll need spyglass to be ready though

@michelle192837
Copy link
Contributor

TestGrid's fine in its current implementation as long as the IDs monotonically increase. It'll need tweaks if not.

@BenTheElder
Copy link
Member

they're monotonic, just with gaps. testgrid is already handling some timestamp IDs so we should be good 👍
http://testgrid.k8s.io/conformance-cloud-provider-openstack#periodic-master

@Katharine
Copy link
Member

Made the required gubernator change in #9911. It's slow.

Gubernator already has fallback logic in case latest-build.txt doesn't exist, so it might instead be preferable to just ensure there is no latest-build.txt?

@Katharine
Copy link
Member

Gubernator changes are live, so that blocker is gone.

@BenTheElder
Copy link
Member

so probably just check kettle and then we can look at deleting the service

@Katharine
Copy link
Member

Looked into this briefly, we also need to set sequential: false as appropriate in kettle/buckets.yaml before we kill tot.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2019
@Katharine
Copy link
Member

Katharine commented Mar 4, 2019

/remove-lifecycle stale

There are no known (to me) blockers on this. We just need to pick a time we don't expect to matter an awful lot if things are on fire. After we work through the merge backlog at the beginning of the 1.15 cycle maybe?

We'll also have to loop in contribex and maybe kubernetes-dev because the numbers will be large and ugly and that's a change.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2019
@Katharine Katharine added this to the v1.15 milestone Mar 4, 2019
@BenTheElder BenTheElder assigned Katharine and unassigned BenTheElder Mar 16, 2019
@spiffxp
Copy link
Member

spiffxp commented Mar 22, 2019

I'm in favor of trying this out, and yes we should give kubernetes-dev@ a heads up. My only ask is that we wait until v1.14 goes out the door.

@Katharine
Copy link
Member

After 1.14 ships is my plan.

@stevekuznetsov
Copy link
Contributor

/woof

@k8s-ci-robot
Copy link
Contributor

@stevekuznetsov: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Mar 23, 2019

/pony snowflake

@k8s-ci-robot
Copy link
Contributor

@spiffxp: pony image

In response to this:

/pony snowflake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Katharine
Copy link
Member

We did it!

/pony cheering
/close

@k8s-ci-robot
Copy link
Contributor

@Katharine: Closing this issue.

In response to this:

We did it!

/pony cheering
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@Katharine: pony image

In response to this:

We did it!

/pony cheering
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzysied
Copy link
Contributor

Hi folks!
Currently we are having issue with perfdash - it doesn't work. kubernetes/perf-tests#469
Assuming that you made changes to the other tools, can someone give hints on how to work with the new run id format? We are using k8s.io/contrib/test-utils/utils/utils.go for accessing the run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gubernator Issues or PRs related to code in /gubernator area/kettle area/prow Issues or PRs related to prow area/testgrid priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests