-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tot with snowflake IDs #9604
Comments
/area gubernator /area kettle /area testgrid |
testgrid should be unimpacted unless we decide to go back, going back would be problematic. gubernator otoh reads latest-build.txt and would be fine. |
/assign @fejta @BenTheElder |
I think testgrid already works fine? not sure about kettle cc @spiffxp |
TestGrid's fine in its current implementation as long as the IDs monotonically increase. It'll need tweaks if not. |
they're monotonic, just with gaps. testgrid is already handling some timestamp IDs so we should be good 👍 |
Made the required gubernator change in #9911. It's slow. Gubernator already has fallback logic in case |
Gubernator changes are live, so that blocker is gone. |
so probably just check kettle and then we can look at deleting the service |
Looked into this briefly, we also need to set |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale There are no known (to me) blockers on this. We just need to pick a time we don't expect to matter an awful lot if things are on fire. After we work through the merge backlog at the beginning of the 1.15 cycle maybe? We'll also have to loop in contribex and maybe kubernetes-dev because the numbers will be large and ugly and that's a change. |
I'm in favor of trying this out, and yes we should give kubernetes-dev@ a heads up. My only ask is that we wait until v1.14 goes out the door. |
After 1.14 ships is my plan. |
/woof |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/pony snowflake |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We did it! /pony cheering |
@Katharine: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi folks! |
ref #9593 (comment)
/area prow
cc @BenTheElder @cjwagner @spiffxp
The text was updated successfully, but these errors were encountered: