Branch Management handbook Update for v1.16

[Bubblemelon]

Contains updates for the upcoming release, added and updated sections, fixed phrasing, fixed formatting and etc.

View full document

To: @idealhack
As future lead, please don't hesitate to let me know if you have any concerns with the changes.

This PR also addresses #659, see section Configure Merge Automation for the added task from test-infra.

CC: @imkin for approval on the above section.

To: @vivektaparia @chrisz100 @SlickNik
Since you all will move on as shadows for the next cycle, please help peer-review/fact-check and let me or @idealhack know if there's any concerns 😃

CC: @tpepper
Just FYI.
I welcome and appreciate your input wherever necessary.

[justaugustus]

/cc

[imkin]

Hey @Bubblemelon Thanks for working on this.

Please add sections for https://github.com/kubernetes/sig-release/tree/master/release-team/role-handbooks/test-infra#create-cipresubmit-jobs-for-the-new-release

Please add a separate page which might link to key resource https://github.com/kubernetes/sig-release/tree/master/release-team/role-handbooks/test-infra#useful-links

Please remove references to test-infra team and add references to "test-infra-oncall", sig-testing, testing-ops channel.

Add to the requirements section for lead and shadow the added load of doing these tasks.

[imkin]

/hold

[Bubblemelon]

Re:

Please add sections for https://github.com/kubernetes/sig-release/tree/master/release-team/role-handbooks/test-infra#create-cipresubmit-jobs-for-the-new-release

Wasn't this the section that CI Signal was taking over but @jberkus opposed. So is Bug Triage taking over? And is there a link to that discussion somewhere?

[Bubblemelon]

Re:

Please add a separate page which might link to key resource https://github.com/kubernetes/sig-release/tree/master/release-team/role-handbooks/test-infra#useful-links

Would it be better to take content from the Useful Links section and elaborate under Viewing test results in k/test-infra ? Since some are duplicates in "View test results" already?

[imkin]

@Bubblemelon
The proposal was I would initially suggest that config editing should fall to the branch manager as part of the branch cut process. And this stood well through the discussions. Forking on new jobs is tied to creation of the new release branch. It should involve CI-signal to review the dashboards in the PR.

[imkin]

Re:

Would it be better to take content from the Useful Links section and elaborate under Viewing test results in k/test-infra ? Since some are duplicates in "View test results" already?

These links were constructed over time to have a "one place" to view the important/useful links for anyone performing these duties. The test-infra documentation is too detailed and the links are spread across multiple mark-downs. One should always read through test-infra documentation but to get a quick set of links this one helped us.

[chrisz100]

/cc

[justaugustus]

The PR is already on hold, but just mentioning here that I'd like to thoroughly review this before it goes in.

First things first...

@Bubblemelon -- can you squash these commits?
I'd feel a little differently if it was a code change, but since it's markdown, let's just tighten up the git history and add a great body to the commit message:

• http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
• https://thoughtbot.com/blog/5-useful-tips-for-a-better-commit-message

[tpepper]

I too want to give this a thorough read/comment...expect to in the next couple days.

[idealhack]

Thanks for updating this, I'll finish the review hopefully before... or after the KubeCon.

[idealhack]

I'll take the time to read through docs and discussions about the change to merge in test-infra responsibilities too.

[Bubblemelon]

Re:

can you squash these commits?

Yup, I'll squash all the commits into one when the changes are finalized 😄

[Bubblemelon]

Note to self: Add shadow requirements/expectations

[palnabarun]

Hi everyone,

I see that the shadows are already decided for this role. Are there any more available shadow positions?

I was really interested to be working in the release team as a Branch Manager Shadow.

PS: I am a first timer. :)

[justaugustus]

@palnabarun -- the application for Kubernetes 1.16 shadows is still open! Please fill it out here: https://docs.google.com/forms/d/e/1FAIpQLSe5voYfOk1pDyjBwotC0go8u0iFtiUpN8iN0LZ8K15dezW6oQ/viewform

[idealhack]

@palnabarun hey, thanks for your interests in this role. we haven't decided shadows for this cycle yet, so feel free to apply for it and/or other roles :)

[tpepper]

All in all very nice restructure and streamlining. I've made quite a few comments but all are relatively minor requests I think. The two main things I'm seeing:

• move the TODO/NB's out of the document into issues (mea culpa...I should have done that multiple versions ago). That could also be left for a shadow to drive discussions and Q&A with them?
• with the other good ordering/sectioning refactors, the need to shift the code management tasks (branchff, reverts, cherry picks) into a cohesive section of its own seems more apparent now.

Thanks for taking the time to do all this cleaning!

(also should squash the commits into one)

[Bubblemelon]

This issue #696 was opened to group the TODO items from the handbook in one place.

[justaugustus]

Thanks @Bubblemelon; looks great! :)
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bubblemelon, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• release-engineering/OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justaugustus]

/hold cancel