-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add self to aws-ebs-csi-driver maintainers/admins list #3721
Conversation
Welcome @ConnorJC3! |
Hi @ConnorJC3. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @wongma7 when you have a chance, thanks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Connor Catlett <[email protected]>
/retest |
@ConnorJC3: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wongma7 sorry, didn't realize the usernames had to be in alphabetical order. When you get a chance can you re-lgtm, thanks! |
/lgtm |
@ConnorJC3: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest I think your PR is still not sorted properly |
@cblecker it's passing all the tests for me, do I have to sort it some weird way? |
/ok-totest |
hmm..weird, the needs-ok-to-test label is still on there. Might need to manually remove it. EDIT: LOL woops, it'd help if I spelled it correctly. |
/ok-to-test |
As the list is the same one @wongma7 previously LGTM'd, but just now sorted: |
xref: #3716
xref: kubernetes-sigs/aws-ebs-csi-driver#1399
Signed-off-by: Connor Catlett [email protected]