Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tarballs for each OS, Generate SHA-512 Checksums, and make Makefile easier to expand OS-Arch options. #545

Merged
merged 1 commit into from
May 10, 2021

Conversation

jeremyje
Copy link
Contributor

@jeremyje jeremyje commented Apr 23, 2021

This change primarily extends the Makefile so that OS-Architecture specific tarballs are produced during make build-tar. Each tarballs will be suffixed with $(GOOS)_$(GOARCH).tar.gz. For example node-problem-detector-v0.8.7-linux_amd64.tar.gz.

This change is backwards compatible so the original file locations will be preserved. The new locations are produced in an output/$(GOOS)_$(GOARCH)/ directory which acts as a staging area for the tarball contents.

make build-tar will now produce tarballs for Linux and Windows.
make push-tar will also push those tarballs to GCS.

*.tar.gz.sha512 checksum files are also produced for the new OS-Arch specific tarballs.
The Makefile has been tuned to allow it to be extended for different OS-Architectures in the future.

This change is primarily for #461 but also helps #135.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2021
@jeremyje
Copy link
Contributor Author

jeremyje commented May 4, 2021 via email

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2021
@jeremyje
Copy link
Contributor Author

jeremyje commented May 6, 2021

I'm adding back the ./bin/* makefile rules because it can break the build if a user specifies make GOOS=arm64 ENABLE_JOURNALD=0 build-tar. The output will be a amd64 tarball rather than an arm64 tarball.

@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit c7ce65d into kubernetes:master May 10, 2021
@jeremyje jeremyje deleted the multi branch May 10, 2021 21:28
@jeremyje
Copy link
Contributor Author

/sig windows
/sig node

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants