-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Tarballs for each OS, Generate SHA-512 Checksums, and make Makefile easier to expand OS-Arch options. #545
Conversation
I'm adding back the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyje, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig windows |
This change primarily extends the
Makefile
so that OS-Architecture specific tarballs are produced duringmake build-tar
. Each tarballs will be suffixed with$(GOOS)_$(GOARCH).tar.gz
. For examplenode-problem-detector-v0.8.7-linux_amd64.tar.gz
.This change is backwards compatible so the original file locations will be preserved. The new locations are produced in an
output/$(GOOS)_$(GOARCH)/
directory which acts as a staging area for the tarball contents.make build-tar
will now produce tarballs for Linux and Windows.make push-tar
will also push those tarballs to GCS.*.tar.gz.sha512
checksum files are also produced for the new OS-Arch specific tarballs.The
Makefile
has been tuned to allow it to be extended for different OS-Architectures in the future.This change is primarily for #461 but also helps #135.