Support waiting for kube-apiserver to be ready with timout during NPD startup #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
wangzhen127
reviewed
Jul 9, 2019
|
|
||
| glog.Infof("Waiting for kube-apiserver to be ready (timeout %v)...", npdo.APIServerWaitTimeout) | ||
| if err := waitForAPIServerReadyWithTimeout(c, npdo); err != nil { | ||
| glog.Warningf("kube-apiserver did not become ready: %v", err) |
There was a problem hiding this comment.
What's the error message when timeout happens? Just want to make sure something like time out waiting for the kube-apiserver is included in the warning message.
There was a problem hiding this comment.
Added more info to the message.
For example:
W0709 10:30:01.060769 231463 k8s_exporter.go:56] kube-apiserver did not become ready: timed out on waiting for kube-apiserver to return the node object: timed out waiting for the condition
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wangzhen127, yguo0905 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 15, 2019
Cherry pick #308 to v0.6: Support waiting for kube-apiserver to be ready with timout during NPD startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
Manually tested using a cluster.
/assign @wangzhen127 @Random-Liu