-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve integration test for delete kubeconfig context #6567
Conversation
update the test to use exitcode as as assertion and to print stdout for debugging easily in error case Signed-off-by: anencore94 <[email protected]>
Hi @anencore94. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anencore94 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #6567 +/- ##
======================================
Coverage 38.1% 38.1%
======================================
Files 137 137
Lines 8690 8690
======================================
Hits 3311 3311
Misses 4963 4963
Partials 416 416 |
/ok-to-test |
All Times Minikube (PR 6567): [ 90.721591 93.736556 94.804227] Average minikube: 91.080051 Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you I tested the new command format for kubectl and it works !
with what I have on my machine "kubectl v1.17.2"
I like this PR makes its more simple and more obvious what went wrong
medya@~/workspace/minikube (crio_runtime) $ kubectl config get-contexts p2
CURRENT NAME CLUSTER AUTHINFO NAMESPACE
* p2 p2 p2
medya@~/workspace/minikube (crio_runtime) $ kubectl config get-contexts x4
CURRENT NAME CLUSTER AUTHINFO NAMESPACE
error: context x4 not found
update the test to use exitcode as as assertion and to print stdout for debugging easily in error case Signed-off-by: anencore94 <[email protected]>
update the test to use exitcode as as assertion
and to print stdout for debugging easily in error
case
applying review in #6541 from @tstromberg