Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve integration test for delete kubeconfig context #6567

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

anencore94
Copy link
Contributor

update the test to use exitcode as as assertion
and to print stdout for debugging easily in error
case

applying review in #6541 from @tstromberg

update the test to use exitcode as as assertion
and to print stdout for debugging easily in error
case

Signed-off-by: anencore94 <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @anencore94. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anencore94
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #6567 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6567   +/-   ##
======================================
  Coverage    38.1%   38.1%           
======================================
  Files         137     137           
  Lines        8690    8690           
======================================
  Hits         3311    3311           
  Misses       4963    4963           
  Partials      416     416

@medyagh
Copy link
Member

medyagh commented Feb 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2020
@minikube-pr-bot
Copy link

All Times Minikube (PR 6567): [ 90.721591 93.736556 94.804227]
All Times minikube: [ 90.903791 89.846395 92.489968]

Average minikube: 91.080051
Average Minikube (PR 6567): 93.087458

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6567) |
+----------------------+-----------+--------------------+
| minikube v           |  0.199502 |           0.198473 |
| Creating kvm2        | 19.576529 |          20.419145 |
| Preparing Kubernetes | 48.760061 |          49.174362 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.335313 |          21.058775 |
| Waiting for cluster  |  0.218106 |           0.076175 |
+----------------------+-----------+--------------------+

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you I tested the new command format for kubectl and it works !
with what I have on my machine "kubectl v1.17.2"
I like this PR makes its more simple and more obvious what went wrong

medya@~/workspace/minikube (crio_runtime) $ kubectl config get-contexts p2
CURRENT   NAME   CLUSTER   AUTHINFO   NAMESPACE
*         p2     p2        p2         
medya@~/workspace/minikube (crio_runtime) $ kubectl config get-contexts x4
CURRENT   NAME   CLUSTER   AUTHINFO   NAMESPACE
error: context x4 not found

@medyagh medyagh changed the title Update delete-config-context test improve integration test for delete kubeconfig context Feb 10, 2020
@medyagh medyagh merged commit 6540cfa into kubernetes:master Feb 10, 2020
medyagh pushed a commit to medyagh/minikube that referenced this pull request Feb 10, 2020
update the test to use exitcode as as assertion
and to print stdout for debugging easily in error
case

Signed-off-by: anencore94 <[email protected]>
@anencore94 anencore94 deleted the updateDeleteContextTest branch February 11, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants