Add ingress-dns addon #5507
Merged
Add ingress-dns addon #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
woodcockjosh
force-pushed
the
add-dns-ingress-addon
branch
from
a0d0d02 to
ea1c00a
Compare
Codecov Report
@@ Coverage Diff @@
## master #5507 +/- ##
==========================================
+ Coverage 36.57% 36.63% +0.06%
==========================================
Files 102 102
Lines 7320 7346 +26
==========================================
+ Hits 2677 2691 +14
- Misses 4292 4298 +6
- Partials 351 357 +6
|
Travis tests have failedHey @woodcockjosh, 1st Buildmake testTravisBuddy Request Identifier: c4428fe0-e3f5-11e9-98d3-55f5e12e8fe5 |
|
The Travis test are failing on |
|
/assign @sharifelgamal |
This was referenced Oct 1, 2019
woodcockjosh
force-pushed
the
add-dns-ingress-addon
branch
2 times, most recently
from
73068eb to
48bdc88
Compare
woodcockjosh
force-pushed
the
add-dns-ingress-addon
branch
from
48bdc88 to
22cface
Compare
|
@minikube-bot OK to test |
|
this is exciting addon ! makes a a lot of things easier. thank you |
|
@medyagh I believe you need |
@woodcockjosh we have a different setup than kubernetes, I know it confuses people, we have a jenkins that is setup to respond to the keyword comment from the maintainers. |
|
@woodcockjosh how about adding a short tutorial to the site too for how to use this addonn ? one small concern I have is the images that are used, seems to be from https://github.com/superbrothers/minikube-ingress-dns |
I certainly don't mind doing this, but can we do as a separate PR? I think we need some type of beta period to make sure everything is good. We have tested this only in a limited context and we may discover that things don't work as expected on all operating systems and vm configurations. Also I think there are some things that I might put in a tutorial which could become irrelevant if this is implemented #5511
As mentioned in our slack discussion the image is here: https://cloud.docker.com/u/cryptexlabs/repository/docker/cryptexlabs/minikube-ingress-dns The repository as mentioned on dockerhub is here: |
|
looks good ! thank you for this great addon and adding more information about the addon source of image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon enables minikube to act as a DNS service for the host OS for ingress hostnames. The ingress hostnames resolve the the minikube ip address. Upon lookup failure the dns lookup falls back to google's DNS servers.