Improve parallel run reliability by putting lock on files before writing #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
medyagh
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/L
medyagh
changed the title
medyagh
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
medyagh
changed the title
k8s-ci-robot
added
size/XL
tstromberg
suggested changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes start race: x509: certificate is valid for <ips>, not <ip> #4967 and maybe http: TLS handshake error from 127.0.0.1:58378: remote error: tls: bad certificate #5040
Provide a decorative wrapper arround ioutil.WriteFile that locks the file before writing
Provide more reliable parallel minikube experience by locking write file for following operations:
-- minikube config
-- profile config
-- cert generation
-- notify write time
-- kubeconfig update
-- mount file
-- extract
Added Exponential Retry logic for acquiring the lock (retry up to 13 seconds)
Converted all the retry across minikube codebase to exponential retry
NOTE1: this lock mechanism is only respected by minikube binaries. not by other procs in the OS.
(which is mostly okay!)