Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm with None driver deletes other local docker images #2705

Closed
bh4rtp opened this issue Apr 11, 2018 · 14 comments
Closed

kubeadm with None driver deletes other local docker images #2705

bh4rtp opened this issue Apr 11, 2018 · 14 comments
Labels
co/kubeadm Issues relating to kubeadm co/none-driver kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bh4rtp
Copy link

bh4rtp commented Apr 11, 2018

The minikube 0.26.0 was installed successfully. But there is a serious problem. On my ubuntu 16.04 virtualbox vm, I have pulled k8s images for minikube dashboard. After running sudo -E minikube start --vm-driver=none, all the docker images including my private images such as hyperledger fabric are deleted without any notification!!

@bh4rtp
Copy link
Author

bh4rtp commented Apr 11, 2018

the docker images are deleted when running minikube dashboard, not minikube start.

@antonyisoardi
Copy link

Yeah I had something like this as well, except it's not when you start dashboard or start Minikube.

I reverted to 0.25 and everything went back to normal.

@bh4rtp
Copy link
Author

bh4rtp commented May 10, 2018

i am using 0.25.0. yesterday, all my local docker images were deleted too. feel strange.

@muthmano-dev
Copy link

I am also seeing this, although I'm using minikube V0.28.0. Any update on this issue?

@dlorenc
Copy link
Contributor

dlorenc commented Jun 19, 2018

My guess is that this is the kubelet image garbage collector. It's probably unavoidable when using the none driver - the kubelet assumes full control over the machine and docker daemon.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2018
@tstromberg tstromberg changed the title start minikube 0.26.0 will delete all the docker images locally kubeadm with None driver deletes other local docker images Sep 19, 2018
@tstromberg tstromberg added kind/documentation Categorizes issue or PR as related to documentation. co/none-driver co/kubeadm Issues relating to kubeadm labels Sep 19, 2018
@tstromberg
Copy link
Contributor

It would be nice if kubeadm, or at least ourselves, could detect this possibility and prompt the user rather than quietly deleting everything.

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Sep 19, 2018
@bhack
Copy link

bhack commented Oct 10, 2018

Can we interact with kubernetes/kubernetes#68930 to find a solution?

@zhangmingld
Copy link

It would be nice if kubeadm, or at least ourselves, could detect this possibility and prompt the user rather than quietly deleting everything.

we add some code in kubelet that user can specify a list of image that garbage will ignore here
maybe it can fix this
kubernetes/kubernetes#68549

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 14, 2018
@bhack
Copy link

bhack commented Nov 14, 2018

Don't stale this

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tstromberg
Copy link
Contributor

tstromberg commented Feb 16, 2019

FWIW, If this was indeed caused by the kubelet reaping disk space, I believe this was fixed by #3671 - which is part of minikube v0.34.0. If this is not the case, please re-open. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/kubeadm Issues relating to kubeadm co/none-driver kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

9 participants