-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using dockerfile/* images #6917
Stop using dockerfile/* images #6917
Conversation
Please review carefully - this was done mostly mechanically. |
Running e2e now |
It looks like this breaks the unit tests
|
68150bc
to
be135cb
Compare
The regex for extracting sample code was broken. Fixed in newest push, starting e2e now |
@smarterclayton for regex and related comment |
@@ -217,7 +217,7 @@ Once the docker image for nginx has been downloaded, the container will start an | |||
$ sudo salt '*minion-1' cmd.run 'docker ps' | |||
kubernetes-minion-1: | |||
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES | |||
dbe79bf6e25b dockerfile/nginx:latest "nginx" 21 seconds ago Up 19 seconds k8s--mynginx.8c5b8a3a--7813c8bd_-_3ffe_-_11e4_-_9036_-_0800279696e1.etcd--7813c8bd_-_3ffe_-_11e4_-_9036_-_0800279696e1--fcfa837f | |||
dbe79bf6e25b nginx :latest "nginx" 21 seconds ago Up 19 seconds k8s--mynginx.8c5b8a3a--7813c8bd_-_3ffe_-_11e4_-_9036_-_0800279696e1.etcd--7813c8bd_-_3ffe_-_11e4_-_9036_-_0800279696e1--fcfa837f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing got put in the wrong spot :)
LGTM other than the one messed up line. Thanks for adding comments to the regex! |
As per http://blog.docker.com/2015/03/updates-available-to-popular-repos-update-your-images/ docker has stopped answering dockerfile/redis and dockerfile/nginx. Fix all users in our tree. Sadly this means a lot of published examples are now broken.
be135cb
to
c2bacd5
Compare
fixed the messed up line, e2e is still running |
Looks fine to me. |
e2e SUCCESS! |
Stop using dockerfile/* images
As per
http://blog.docker.com/2015/03/updates-available-to-popular-repos-update-your-images/
docker has stopped answering dockerfile/redis and dockerfile/nginx. Fix all
users in our tree. Sadly this means a lot of published examples are now broken.
I don't know why they didn't just make these aliases to their replacements. Sigh.
Fixes #6914